Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1213)

Unified Diff: chrome/browser/favicon/favicon_service.h

Issue 26563004: Find Favicon in priority of icon_type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_service.cc » ('j') | chrome/browser/favicon/favicon_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_service.h
diff --git a/chrome/browser/favicon/favicon_service.h b/chrome/browser/favicon/favicon_service.h
index 692a6ebe74e1d570670da09befcfc51ec8658a50..58deaa849faf58421eb082977ea8c579d9de1892 100644
--- a/chrome/browser/favicon/favicon_service.h
+++ b/chrome/browser/favicon/favicon_service.h
@@ -172,6 +172,15 @@ class FaviconService : public CancelableRequestProvider,
const FaviconRawCallback& callback,
CancelableTaskTracker* tracker);
+ // See history::HistoryService::GetLargestFaviconForURL.
+ CancelableTaskTracker::TaskId GetLargestRawFaviconForURL(
+ Profile* profile,
+ const GURL& page_url,
+ const std::vector<int>& icon_types,
+ int minimal_size_in_pixels,
+ const FaviconRawCallback& callback,
+ CancelableTaskTracker* tracker);
+
CancelableTaskTracker::TaskId GetFaviconForURL(
const FaviconForURLParams& params,
const FaviconResultsCallback& callback,
@@ -246,6 +255,14 @@ class FaviconService : public CancelableRequestProvider,
const FaviconResultsCallback& callback,
CancelableTaskTracker* tracker);
+ CancelableTaskTracker::TaskId GetLargestRawFaviconForURLImpl(
+ Profile* profile,
+ const GURL& page_url,
+ const std::vector<int>& icon_types,
+ int minimal_size_in_pixels,
+ const FaviconResultsCallback& callback,
+ CancelableTaskTracker* tracker);
+
// Intermediate callback for GetFaviconImage() and GetFaviconImageForURL()
// so that history service can deal solely with FaviconResultsCallback.
// Builds chrome::FaviconImageResult from |favicon_bitmap_results| and runs
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_service.cc » ('j') | chrome/browser/favicon/favicon_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698