Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1597)

Unified Diff: chrome/browser/favicon/favicon_service.h

Issue 26563004: Find Favicon in priority of icon_type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_service.h
diff --git a/chrome/browser/favicon/favicon_service.h b/chrome/browser/favicon/favicon_service.h
index 692a6ebe74e1d570670da09befcfc51ec8658a50..ed1bc3d249530c8c511cd3dbd45d4e6279ec072c 100644
--- a/chrome/browser/favicon/favicon_service.h
+++ b/chrome/browser/favicon/favicon_service.h
@@ -67,11 +67,9 @@ class FaviconService : public CancelableRequestProvider,
typedef base::Callback<void(const chrome::FaviconImageResult&)>
FaviconImageCallback;
- // Callback for GetRawFavicon() and GetRawFaviconForURL().
- // FaviconBitmapResult::bitmap_data is the bitmap in the thumbnail database
- // for the passed in URL and icon types whose pixel size best matches the
- // passed in |desired_size_in_dip| and |desired_scale_factor|. Returns an
- // invalid chrome::FaviconBitmapResult if there are no matches.
+ // Callback for GetRawFavicon(), GetRawFaviconForURL() and
+ // GetLargestRawFavicon().
+ // See function for details on value.
typedef base::Callback<void(const chrome::FaviconBitmapResult&)>
FaviconRawCallback;
@@ -172,6 +170,15 @@ class FaviconService : public CancelableRequestProvider,
const FaviconRawCallback& callback,
CancelableTaskTracker* tracker);
+ // See HistoryService::GetLargestFaviconForURL().
+ CancelableTaskTracker::TaskId GetLargestRawFaviconForURL(
+ Profile* profile,
+ const GURL& page_url,
+ const std::vector<int>& icon_types,
+ int minimum_size_in_pixels,
+ const FaviconRawCallback& callback,
+ CancelableTaskTracker* tracker);
+
CancelableTaskTracker::TaskId GetFaviconForURL(
const FaviconForURLParams& params,
const FaviconResultsCallback& callback,
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698