Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2106)

Unified Diff: chrome/browser/favicon/favicon_service.cc

Issue 26563004: Find Favicon in priority of icon_type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/favicon/favicon_service.cc
diff --git a/chrome/browser/favicon/favicon_service.cc b/chrome/browser/favicon/favicon_service.cc
index fd0f9eb557c4cd9931b4a70dee6df9e80020add7..4e44405f9d6f063a8fc8c3fedd433eb2c9a247ae 100644
--- a/chrome/browser/favicon/favicon_service.cc
+++ b/chrome/browser/favicon/favicon_service.cc
@@ -294,12 +294,8 @@ CancelableTaskTracker::TaskId FaviconService::GetFaviconForURLImpl(
params.profile, params.page_url, desired_scale_factors, cancelable_cb);
return id;
} else if (history_service_) {
- return history_service_->GetFaviconsForURL(params.page_url,
- params.icon_types,
- params.desired_size_in_dip,
- desired_scale_factors,
- callback,
- tracker);
+ return history_service_->GetFaviconsForURL(params, desired_scale_factors,
+ callback, tracker);
} else {
return RunWithEmptyResultAsync(callback, tracker);
}

Powered by Google App Engine
This is Rietveld 408576698