chrome/browser/history/history_backend.h - Issue 26563004: Find Favicon in priority of icon_type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_backend.h

Issue 26563004: Find Favicon in priority of icon_type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/history/history_backend.h

diff --git a/chrome/browser/history/history_backend.h b/chrome/browser/history/history_backend.h

index f3bbf4d9ebe943189c1f474a278211ef77a83d2d..d7b97dc6b931c85c35c31d03d847aa37cb64cb1e 100644

--- a/chrome/browser/history/history_backend.h

+++ b/chrome/browser/history/history_backend.h

@@ -244,9 +244,10 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,

void GetFaviconsForURL(

const GURL& page_url,

- int icon_types,

+ const std::vector<int>& icon_types_priority,

sky 2013/10/10 20:35:12 icon_types_priority->icon_types here and every whe

michaelbai 2013/10/10 22:39:58 Done.

int desired_size_in_dip,

const std::vector<ui::ScaleFactor>& desired_scale_factors,

+ int threshold_for_next_icon_types,

std::vector<chrome::FaviconBitmapResult>* bitmap_results);

void GetFaviconForID(