Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: chrome/browser/history/history_service.h

Issue 26563004: Find Favicon in priority of icon_type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_backend_unittest.cc ('k') | chrome/browser/history/history_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_service.h
diff --git a/chrome/browser/history/history_service.h b/chrome/browser/history/history_service.h
index 6891f38e71498c86140cb025cf5bfcdd1afeb5a2..fca534ae229da797c122db864ae01f1bc4bae49e 100644
--- a/chrome/browser/history/history_service.h
+++ b/chrome/browser/history/history_service.h
@@ -707,6 +707,24 @@ class HistoryService : public CancelableRequestProvider,
const FaviconService::FaviconResultsCallback& callback,
CancelableTaskTracker* tracker);
+ // Used by FaviconService to find the first favicon bitmap whose width and
+ // height are greater than that of |minimum_size_in_pixels|. This searches
+ // for icons by IconType. Each element of |icon_types| is a bitmask of
+ // IconTypes indicating the types to search for.
+ // If the largest icon of |icon_types[0]| is not larger than
+ // |minimum_size_in_pixel|, the next icon types of
+ // |icon_types| will be searched and so on.
+ // If no icon is larger than |minimum_size_in_pixel|, the largest one of all
+ // icon types in |icon_types| is returned.
+ // This feature is especially useful when some types of icon is perfered as
+ // long as its size is larger than a specific value.
+ CancelableTaskTracker::TaskId GetLargestFaviconForURL(
+ const GURL& page_url,
+ const std::vector<int>& icon_types,
+ int minimum_size_in_pixels,
+ const FaviconService::FaviconRawCallback& callback,
sky 2013/10/18 14:11:40 Update docs for FaviconRawCallback too.
michaelbai 2013/10/18 17:31:48 Done.
+ CancelableTaskTracker* tracker);
+
// Used by the FaviconService to get the favicon bitmap which most closely
// matches |desired_size_in_dip| and |desired_scale_factor| from the favicon
// with |favicon_id| from the history backend. If |desired_size_in_dip| is 0,
« no previous file with comments | « chrome/browser/history/history_backend_unittest.cc ('k') | chrome/browser/history/history_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698