Find Favicon in priority of icon_type.

chrome/browser/history/history_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The history system runs on a background thread so that potentially slow
 // database operations don't delay the browser. This backend processing is
 // represented by HistoryBackend. The HistoryService's job is to dispatch to
 // that thread.
 //
 // Main thread                       History thread
@@ skipping 626 matching lines @@
       base::Bind(&HistoryBackend::GetFaviconsForURL,
                  history_backend_.get(),
                  page_url,
                  icon_types,
                  desired_size_in_dip,
                  desired_scale_factors,
                  results),
       base::Bind(&RunWithFaviconResults, callback, base::Owned(results)));
 }
 
+CancelableTaskTracker::TaskId HistoryService::GetLargestFaviconForURL(
+    const GURL& page_url,
+    const std::vector<int>& icon_types,
+    int minimal_size_in_pixels,
+    const FaviconService::FaviconResultsCallback& callback,
+    CancelableTaskTracker* tracker) {
+    DCHECK(thread_checker_.CalledOnValidThread());

[pkotwicz, 2013/10/16 16:59:41]

Nit: DCHECK should be indented with LoadBackendIfNecessary()

[michaelbai, 2013/10/16 18:17:05]

Done.

+  LoadBackendIfNecessary();
+
+  std::vector<chrome::FaviconBitmapResult>* results =
+      new std::vector<chrome::FaviconBitmapResult>();
+  return tracker->PostTaskAndReply(
+      thread_->message_loop_proxy().get(),
+      FROM_HERE,
+      base::Bind(&HistoryBackend::GetLargestFaviconForURL,
+                 history_backend_.get(),
+                 page_url,
+                 icon_types,
+                 minimal_size_in_pixels,
+                 results),
+      base::Bind(&RunWithFaviconResults, callback, base::Owned(results)));
+}
+
 CancelableTaskTracker::TaskId HistoryService::GetFaviconForID(
     chrome::FaviconID favicon_id,
     int desired_size_in_dip,
     ui::ScaleFactor desired_scale_factor,
     const FaviconService::FaviconResultsCallback& callback,
     CancelableTaskTracker* tracker) {
   DCHECK(thread_checker_.CalledOnValidThread());
   LoadBackendIfNecessary();
 
   std::vector<chrome::FaviconBitmapResult>* results =
@@ skipping 584 matching lines @@
   DCHECK(thread_checker_.CalledOnValidThread());
   visit_database_observers_.RemoveObserver(observer);
 }
 
 void HistoryService::NotifyVisitDBObserversOnAddVisit(
     const history::BriefVisitInfo& info) {
   DCHECK(thread_checker_.CalledOnValidThread());
   FOR_EACH_OBSERVER(history::VisitDatabaseObserver, visit_database_observers_,
                     OnAddVisit(info));
 }