Find Favicon in priority of icon_type.

chrome/browser/history/history_backend.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_
 #define CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_
 
 #include <set>
 #include <string>
 #include <utility>
@@ skipping 226 matching lines @@
   // Favicon -------------------------------------------------------------------
 
   void GetFavicons(const std::vector<GURL>& icon_urls,
                     int icon_types,
                     int desired_size_in_dip,
                     const std::vector<ui::ScaleFactor>& desired_scale_factors,
                     std::vector<chrome::FaviconBitmapResult>* bitmap_results);
 
   void GetFaviconsForURL(
       const GURL& page_url,
-      int icon_types,
+      const std::vector<int>& icon_types_priority,

[sky, 2013/10/08 23:47:52]

icon_types_priority->icon_types

[michaelbai, 2013/10/10 05:51:43]

As element of the list could be a composition of icon_type, this name might
better than 'icon_types'

On 2013/10/08 23:47:52, sky wrote:

[sky, 2013/10/10 20:35:12]

I don't get this. Why do we need the ability to support *both* an ordered list
containing bitmasks and IconTypes. Can't we make it only an ordered list of
IconTypes? If you say no, why? What specific use case do you have that requires
a vector of bitmasks?

[michaelbai, 2013/10/10 22:39:58]

The use case is we want use favicon first if it is larger than normal size, if
not, the largest icon of touch_icon or precomposed_touch_icon would work, if
there is no touch_icon or precomposed_touch_icon, normal favicon will be used.

In this case, icon_types the vector should be
icon_types.push_back(FAVICON);
icon_types.push_back(TOUCH_ICON|PRECOMPOSED_TOUCH_ICON);


On 2013/10/10 20:35:12, sky wrote:

       int desired_size_in_dip,
       const std::vector<ui::ScaleFactor>& desired_scale_factors,
+      int threshold_for_next_icon_types,
       std::vector<chrome::FaviconBitmapResult>* bitmap_results);
 
   void GetFaviconForID(
       chrome::FaviconID favicon_id,
       int desired_size_in_dip,
       ui::ScaleFactor desired_scale_factor,
       std::vector<chrome::FaviconBitmapResult>* bitmap_results);
 
   void UpdateFaviconMappingsAndFetch(
       const GURL& page_url,
@@ skipping 649 matching lines @@
 
   // Listens for the system being under memory pressure.
   scoped_ptr<base::MemoryPressureListener> memory_pressure_listener_;
 
   DISALLOW_COPY_AND_ASSIGN(HistoryBackend);
 };
 
 }  // namespace history
 
 #endif  // CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_