Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2656293002: Update clang-format binaries and scripts for all platforms (take 2). (Closed)

Created:
3 years, 11 months ago by Dan Beam
Modified:
3 years, 11 months ago
Reviewers:
Nico
Target Ref:
refs/heads/master
Project:
buildtools
Visibility:
Public.

Description

Update clang-format binaries and scripts for all platforms (take 2). This time, with valid script/ SHA1! I followed these instructions: https://chromium.googlesource.com/chromium/src/+/master/docs/updating_clang_format_binaries.md The binaries were built at clang revision 290930 on Wed Jan 25 19:54:51 PST 2017 BUG=567770 R=thakis@chromium.org Committed: c302711306f19ec9d29ac3461b09ecd4c781fac0

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 3 comments Download
M clang_format/README.chromium View 1 chunk +2 lines, -2 lines 1 comment Download
M linux64/clang-format.sha1 View 1 chunk +1 line, -1 line 1 comment Download
M mac/clang-format.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M win/clang-format.exe.sha1 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Dan Beam
https://codereview.chromium.org/2656293002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/2656293002/diff/1/DEPS#newcode6 DEPS:6: "clang_format_rev": "4be7a6c06697b4300179feccfb49be43a0f8d3df", # r289428 note: I think this is ...
3 years, 11 months ago (2017-01-27 02:30:06 UTC) #1
Nico
lgtm (For relands, I usually upload the original change as patch set 1 and the ...
3 years, 11 months ago (2017-01-27 02:35:27 UTC) #3
Dan Beam
https://codereview.chromium.org/2656293002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/2656293002/diff/1/DEPS#newcode6 DEPS:6: "clang_format_rev": "4be7a6c06697b4300179feccfb49be43a0f8d3df", # r289428 On 2017/01/27 02:35:27, Nico wrote: ...
3 years, 11 months ago (2017-01-27 02:39:46 UTC) #4
Nico
As I said, up to you. As-is is fine if you like that better. https://codereview.chromium.org/2656293002/diff/1/clang_format/README.chromium ...
3 years, 11 months ago (2017-01-27 02:42:59 UTC) #5
Dan Beam
3 years, 11 months ago (2017-01-27 02:43:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c302711306f19ec9d29ac3461b09ecd4c781fac0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698