Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2656233004: Use AnalysisDriver.getErrors() to get cached errors for already analyzed files. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use AnalysisDriver.getErrors() to get cached errors for already analyzed files. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/6bb8a923d311163a71d9fe351f08b897d9710760

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -2 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 2 chunks +67 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 2 chunks +85 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/lib/src/analyzer_impl.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-01-27 21:08:44 UTC) #1
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-01-27 21:22:32 UTC) #2
scheglov
3 years, 10 months ago (2017-01-27 21:26:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6bb8a923d311163a71d9fe351f08b897d9710760 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698