Change effect of flag kDisableAcceleratedVideoDecode to only affect decode

Change effect of flag kDisableAcceleratedVideoDecode from affecting both encode and decode to only affecting decode.

BUG=599650

[chfremer, 2017-01-26 21:28:50]

The CQ bit was checked by chfremer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 21:29:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chfremer, 2017-01-26 21:32:51]

Description was changed from

==========
Change effect of flag kDisableAcceleratedVideoDecode from affecting both encode
and decode to only affecting decode.

BUG=
==========

to

==========
Change effect of flag kDisableAcceleratedVideoDecode from affecting both encode
and decode to only affecting decode.

BUG=599650
==========

[chfremer, 2017-01-26 22:29:08]

chfremer@chromium.org changed reviewers:
+ emircan@chromium.org

[chfremer, 2017-01-26 22:29:09]

emircan@: PTAL

[commit-bot: I haz the power, 2017-01-26 23:54:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 23:54:03]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chfremer, 2017-01-30 21:53:21]

Patchset #2 (id:20001) has been deleted

[chfremer, 2017-01-31 00:36:13]

On 2017/01/26 22:29:09, chfremer wrote:
> emircan@: PTAL

Bot mac_chromium_rel_ng is happy after a simple re-run.
PTAL.

[emircan, 2017-01-31 18:50:42]

lgtm

[chfremer, 2017-01-31 18:58:14]

chfremer@chromium.org changed reviewers:
+ avi@chromium.org, dalecurtis@chromium.org

[chfremer, 2017-01-31 18:58:14]

avi@: Please RS content/*
dalecurtis@: Please RS media/*

[chfremer, 2017-01-31 19:27:42]

chfremer@chromium.org changed reviewers:
+ jam@chromium.org
- avi@chromium.org

[chfremer, 2017-01-31 19:27:43]

jam@: Please RS content/*

I just noticed that avi@ is OOO

[DaleCurtis, 2017-02-01 00:41:04]

Seems okay. Did you check the blacklist to see if the encoder is being
blacklisted via this mechanism in any cases? lgtm otherwise

[jam, 2017-02-01 01:12:49]

lgtm

[chfremer, 2017-02-01 17:40:15]

The CQ bit was checked by chfremer@chromium.org

[commit-bot: I haz the power, 2017-02-01 17:40:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 19:26:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 19:26:57]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[chfremer, 2017-02-01 20:27:12]

Just double checked the usage sites of the flag kDisableAcceleratedVideoDecode, 
and I somehow missed that webrtc_media_recorder_browsertests are already 
relying on this flag to disable encode acceleration [1].

This means we cannot land this without adding a new mechanism to disable encode 
acceleration, probably a new flag kDisableAcceleratedVideoEncode.

[1]
https://cs.chromium.org/chromium/src/content/browser/webrtc/webrtc_media_reco...

[Pawel Osciak, 2017-02-02 01:16:50]

On 2017/02/01 20:27:12, chfremer wrote:
> Just double checked the usage sites of the flag
kDisableAcceleratedVideoDecode, 
> and I somehow missed that webrtc_media_recorder_browsertests are already 
> relying on this flag to disable encode acceleration [1].
> 
> This means we cannot land this without adding a new mechanism to disable
encode 
> acceleration, probably a new flag kDisableAcceleratedVideoEncode.
> 
> [1]
>
https://cs.chromium.org/chromium/src/content/browser/webrtc/webrtc_media_reco...

Please note we have a kDisableWebRtcHWEncoding flag and a few other related
flags. Ideally it would be great if we were able to reorganize and align them
with decoding flags...