Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/query_parser/snippet.h

Issue 265613002: Roll ICU to icu52 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/extensions/api_test/file_manager_browsertest/test_util.js ('k') | components/query_parser/snippet_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/query_parser/snippet.h
===================================================================
--- components/query_parser/snippet.h (revision 283797)
+++ components/query_parser/snippet.h (working copy)
@@ -33,13 +33,13 @@
// with no overlapping elements.
//
// NOTE: the positions returned are in terms of UTF8 encoding. To convert the
- // offsets to wide, use ConvertMatchPositionsToWide.
+ // offsets to UTF-16, use ConvertMatchPositionsToWide
static void ExtractMatchPositions(const std::string& offsets_str,
const std::string& column_num,
MatchPositions* match_positions);
// Converts match positions as returned from ExtractMatchPositions to be in
- // terms of a wide string.
+ // terms of a UTF-16 2-byte code unit.
static void ConvertMatchPositionsToWide(
const std::string& utf8_string,
Snippet::MatchPositions* match_positions);
« no previous file with comments | « chrome/test/data/extensions/api_test/file_manager_browsertest/test_util.js ('k') | components/query_parser/snippet_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698