Roll ICU to icu52

chrome/browser/translate/translate_manager_render_view_host_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <set>
 #include <vector>
 
+#include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/prefs/pref_change_registrar.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/test_extension_system.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h"
 #include "chrome/browser/translate/translate_infobar_delegate.h"
@@ skipping 577 matching lines @@
     infobar = GetTranslateInfoBar();
     bool expected =
         TranslateDownloadManager::IsSupportedLanguage(lang) && lang != "en";
     EXPECT_EQ(expected, infobar != NULL);
 
     if (infobar != NULL)
       EXPECT_TRUE(CloseTranslateInfoBar());
   }
 }
 
+// A list of languages to fake being returned by the translate server.
+// Use only langauges for which Chrome's copy of ICU has
+// display names in English locale. To save space, Chrome's copy of ICU
+// does not have the display name for a language unless it's in the
+// Accept-Language list.
+static const char* server_language_list[] =
+    {"ach", "ak", "af", "en-CA", "zh", "yi", "fr-FR", "tl", "iw", "in", "xx"};
+static const char* alpha_language_list[] = {"ach", "yi"};
+
 // Test the fetching of languages from the translate server
 TEST_F(TranslateManagerRenderViewHostTest, FetchLanguagesFromTranslateServer) {
   std::vector<std::string> server_languages;
-  // A list of languages to fake being returned by the translate server.
-  server_languages.push_back("aa");
-  server_languages.push_back("ak");
-  server_languages.push_back("ab");
-  server_languages.push_back("en-CA");
-  server_languages.push_back("zh");
-  server_languages.push_back("yi");
-  server_languages.push_back("fr-FR");
-  server_languages.push_back("xx");
+  for (size_t i = 0; i < arraysize(server_language_list); ++i)
+    server_languages.push_back(server_language_list[i]);
 
   std::vector<std::string> alpha_languages;
-  alpha_languages.push_back("aa");
-  alpha_languages.push_back("yi");
+  for (size_t i = 0; i < arraysize(alpha_language_list); ++i)
+    alpha_languages.push_back(alpha_language_list[i]);
 
   // First, get the default languages list. Note that calling
   // GetSupportedLanguages() invokes RequestLanguageList() internally.
   std::vector<std::string> default_supported_languages;
   TranslateDownloadManager::GetSupportedLanguages(&default_supported_languages);
   // To make sure we got the defaults and don't confuse them with the mocks.
   ASSERT_NE(default_supported_languages.size(), server_languages.size());
 
   // Check that we still get the defaults until the URLFetch has completed.
   std::vector<std::string> current_supported_languages;
@@ skipping 15 matching lines @@
   // "xx" can't be displayed in the Translate inforbar, so this is eliminated.
   EXPECT_EQ(server_languages.size() - 1, current_supported_languages.size());
   // Not sure we need to guarantee the order of languages, so we find them.
   for (size_t i = 0; i < server_languages.size(); ++i) {
     const std::string& lang = server_languages[i];
     if (lang == "xx")
       continue;
     EXPECT_NE(current_supported_languages.end(),
               std::find(current_supported_languages.begin(),
                         current_supported_languages.end(),
-                        lang));
+                        lang)) << "lang=" << lang;
     bool is_alpha =
         std::find(alpha_languages.begin(), alpha_languages.end(), lang) !=
         alpha_languages.end();
-    EXPECT_EQ(TranslateDownloadManager::IsAlphaLanguage(lang), is_alpha);
+    EXPECT_EQ(TranslateDownloadManager::IsAlphaLanguage(lang),
+              is_alpha) << "lang=" << lang;
   }
 }
 
 // Test the fetching of languages from the translate server without 'al'
 // parameter.
 TEST_F(TranslateManagerRenderViewHostTest,
        FetchLanguagesFromTranslateServerWithoutAlpha) {
   std::vector<std::string> server_languages;
-  server_languages.push_back("aa");
-  server_languages.push_back("ak");
-  server_languages.push_back("ab");
-  server_languages.push_back("en-CA");
-  server_languages.push_back("zh");
-  server_languages.push_back("yi");
-  server_languages.push_back("fr-FR");
-  server_languages.push_back("xx");
+  for (size_t i = 0; i < arraysize(server_language_list); ++i)
+    server_languages.push_back(server_language_list[i]);
 
   std::vector<std::string> alpha_languages;
-  alpha_languages.push_back("aa");
-  alpha_languages.push_back("yi");
+  for (size_t i = 0; i < arraysize(alpha_language_list); ++i)
+    alpha_languages.push_back(alpha_language_list[i]);
 
   // call GetSupportedLanguages to call RequestLanguageList internally.
   std::vector<std::string> default_supported_languages;
   TranslateDownloadManager::GetSupportedLanguages(&default_supported_languages);
 
   SimulateSupportedLanguagesURLFetch(
       true, server_languages, false, alpha_languages);
 
   std::vector<std::string> current_supported_languages;
   TranslateDownloadManager::GetSupportedLanguages(&current_supported_languages);
 
   // "xx" can't be displayed in the Translate inforbar, so this is eliminated.
   EXPECT_EQ(server_languages.size() - 1, current_supported_languages.size());
 
   for (size_t i = 0; i < server_languages.size(); ++i) {
     const std::string& lang = server_languages[i];
     if (lang == "xx")
       continue;
     EXPECT_NE(current_supported_languages.end(),
               std::find(current_supported_languages.begin(),
                         current_supported_languages.end(),
-                        lang));
-    EXPECT_FALSE(TranslateDownloadManager::IsAlphaLanguage(lang));
+                        lang)) << "lang=" << lang;
+    EXPECT_FALSE(TranslateDownloadManager::IsAlphaLanguage(lang)) <<
+        "lang=" << lang;
   }
 }
 
 // Tests auto-translate on page.
 TEST_F(TranslateManagerRenderViewHostTest, AutoTranslateOnNavigate) {
   SimulateNavigation(GURL("http://www.google.fr"), "fr", true);
 
   // Simulate the user translating.
   TranslateInfoBarDelegate* infobar = GetTranslateInfoBar();
   ASSERT_TRUE(infobar != NULL);
@@ skipping 829 matching lines @@
   // Check the bubble exists instead of the infobar.
   TranslateInfoBarDelegate* infobar = GetTranslateInfoBar();
   ASSERT_TRUE(infobar == NULL);
   TranslateBubbleModel* bubble = factory->model();
   ASSERT_TRUE(bubble != NULL);
   EXPECT_EQ(TranslateBubbleModel::VIEW_STATE_TRANSLATING,
             bubble->GetViewState());
 }
 
 #endif  // defined(USE_AURA)