Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Side by Side Diff: runtime/vm/virtual_memory_macos.cc

Issue 2656123002: Fix refactoring mistake in Mac ~VirtualMemory. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_OS_MACOS) 6 #if defined(TARGET_OS_MACOS)
7 7
8 #include "vm/virtual_memory.h" 8 #include "vm/virtual_memory.h"
9 9
10 #include <sys/mman.h> // NOLINT 10 #include <sys/mman.h> // NOLINT
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 return; 47 return;
48 } 48 }
49 49
50 if (munmap(address, size) != 0) { 50 if (munmap(address, size) != 0) {
51 FATAL("munmap failed\n"); 51 FATAL("munmap failed\n");
52 } 52 }
53 } 53 }
54 54
55 55
56 VirtualMemory::~VirtualMemory() { 56 VirtualMemory::~VirtualMemory() {
57 if (!vm_owns_region()) { 57 if (vm_owns_region()) {
58 unmap(address(), reserved_size_); 58 unmap(address(), reserved_size_);
59 } 59 }
60 } 60 }
61 61
62 62
63 bool VirtualMemory::FreeSubSegment(int32_t handle, 63 bool VirtualMemory::FreeSubSegment(int32_t handle,
64 void* address, 64 void* address,
65 intptr_t size) { 65 intptr_t size) {
66 unmap(address, size); 66 unmap(address, size);
67 return true; 67 return true;
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 prot = PROT_READ | PROT_WRITE | PROT_EXEC; 105 prot = PROT_READ | PROT_WRITE | PROT_EXEC;
106 break; 106 break;
107 } 107 }
108 return (mprotect(reinterpret_cast<void*>(page_address), 108 return (mprotect(reinterpret_cast<void*>(page_address),
109 end_address - page_address, prot) == 0); 109 end_address - page_address, prot) == 0);
110 } 110 }
111 111
112 } // namespace dart 112 } // namespace dart
113 113
114 #endif // defined(TARGET_OS_MACOS) 114 #endif // defined(TARGET_OS_MACOS)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698