tools/gn/ninja_target_writer.cc - Issue 26561005: GYP generator for GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_target_writer.cc

Issue 26561005: GYP generator for GN (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/ninja_target_writer.cc

diff --git a/tools/gn/ninja_target_writer.cc b/tools/gn/ninja_target_writer.cc

index 3eccb180973bf05f501f92b809f6a2b4b82fd244..4bbc1f57c82e024075099e19f524cf3f5c35b075 100644

--- a/tools/gn/ninja_target_writer.cc

+++ b/tools/gn/ninja_target_writer.cc

@@ -59,13 +59,6 @@ void NinjaTargetWriter::RunAndWriteFile(const Target* target) {

// It's rediculously faster to write to a string and then write that to

// disk in one operation than to use an fstream here.

std::stringstream file;

- if (file.fail()) {

- g_scheduler->FailWithError(

- Err(Location(), "Error writing ninja file.",

- "Unable to open \"" + FilePathToUTF8(ninja_file) + "\"\n"

- "for writing."));

- return;

- }

// Call out to the correct sub-type of writer.

if (target->output_type() == Target::COPY_FILES) {

« no previous file with comments | « tools/gn/ninja_build_writer.cc ('k') | tools/gn/secondary/BUILD.gn » ('j') | no next file with comments »