Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: tools/gn/ninja_binary_target_writer.cc

Issue 26561005: GYP generator for GN (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/gyp_target_writer.cc ('k') | tools/gn/ninja_build_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_binary_target_writer.cc
diff --git a/tools/gn/ninja_binary_target_writer.cc b/tools/gn/ninja_binary_target_writer.cc
index 9241021fdcf6c169caa0f0b6ba17b5c8602a91d8..aefb5138e0dc9654e76f1964bc8e9a5ffcf313fe 100644
--- a/tools/gn/ninja_binary_target_writer.cc
+++ b/tools/gn/ninja_binary_target_writer.cc
@@ -333,17 +333,6 @@ void NinjaBinaryTargetWriter::WriteLinkCommand(
path_output_.WriteFile(out_, helper_.GetTargetOutputFile(linkable_deps[i]));
}
- // External link deps from GYP. This is indexed by a label with no toolchain.
- typedef BuildSettings::AdditionalLibsMap LibsMap;
- const LibsMap& libs = settings_->build_settings()->external_link_deps();
- Label libs_key(target_->label().dir(), target_->label().name());
- LibsMap::const_iterator libs_end = libs.upper_bound(libs_key);
- for (LibsMap::const_iterator i = libs.lower_bound(libs_key);
- i != libs_end; ++i) {
- out_ << " ";
- path_output_.WriteFile(out_, i->second);
- }
-
// Append data dependencies as implicit dependencies.
WriteImplicitDependencies(non_linkable_deps);
« no previous file with comments | « tools/gn/gyp_target_writer.cc ('k') | tools/gn/ninja_build_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698