Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/ninja_target_writer.cc

Issue 26561005: GYP generator for GN (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/gn/escape.h ('K') | « tools/gn/ninja_build_writer.cc ('k') | tools/gn/secondary/BUILD.gn » ('j') | tools/gn/secondary/build/config/BUILDCONFIG.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_target_writer.cc
diff --git a/tools/gn/ninja_target_writer.cc b/tools/gn/ninja_target_writer.cc
index 3eccb180973bf05f501f92b809f6a2b4b82fd244..4bbc1f57c82e024075099e19f524cf3f5c35b075 100644
--- a/tools/gn/ninja_target_writer.cc
+++ b/tools/gn/ninja_target_writer.cc
@@ -59,13 +59,6 @@ void NinjaTargetWriter::RunAndWriteFile(const Target* target) {
// It's rediculously faster to write to a string and then write that to
// disk in one operation than to use an fstream here.
std::stringstream file;
- if (file.fail()) {
- g_scheduler->FailWithError(
- Err(Location(), "Error writing ninja file.",
- "Unable to open \"" + FilePathToUTF8(ninja_file) + "\"\n"
- "for writing."));
- return;
- }
// Call out to the correct sub-type of writer.
if (target->output_type() == Target::COPY_FILES) {
« tools/gn/escape.h ('K') | « tools/gn/ninja_build_writer.cc ('k') | tools/gn/secondary/BUILD.gn » ('j') | tools/gn/secondary/build/config/BUILDCONFIG.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698