Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 265603002: Revert of HttpServer: avoid DCHECK'ing on non-HTTP/1.1 requests. (Closed)

Created:
6 years, 7 months ago by henrika (OOO until Aug 14)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of HttpServer: avoid DCHECK'ing on non-HTTP/1.1 requests. (https://codereview.chromium.org/251213004/) Reason for revert: Speculative revert since it might cause http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%282%29/builds/20802. Original issue's description: > HttpServer: avoid DCHECK'ing on non-HTTP/1.1 requests. > > BUG=b/14249697 > R=mef@chromium.org,byungchul@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267066 TBR=byungchul@chromium.org,mef@chromium.org,gunsch@google.com,gunsch@chromium.org NOTREECHECKS=true NOTRY=true BUG=b/14249697 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267149

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -76 lines) Patch
M net/http/http_response_headers.h View 1 chunk +8 lines, -0 lines 0 comments Download
M net/http/http_response_headers.cc View 2 chunks +48 lines, -7 lines 0 comments Download
M net/http/http_util.h View 1 chunk +0 lines, -6 lines 0 comments Download
M net/http/http_util.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M net/server/http_server.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M net/server/http_server_request_info.h View 2 chunks +0 lines, -4 lines 0 comments Download
M net/server/http_server_unittest.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
henrika (OOO until Aug 14)
Created Revert of HttpServer: avoid DCHECK'ing on non-HTTP/1.1 requests.
6 years, 7 months ago (2014-04-30 08:54:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henrika@chromium.org/265603002/1
6 years, 7 months ago (2014-04-30 08:55:15 UTC) #2
commit-bot: I haz the power
Change committed as 267149
6 years, 7 months ago (2014-04-30 09:00:08 UTC) #3
henrika (OOO until Aug 14)
6 years, 7 months ago (2014-04-30 10:59:47 UTC) #4
Message was sent while issue was closed. 
Seems like the revert did the trick and we are now green.

http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%28...

Powered by Google App Engine
This is Rietveld 408576698