extensions/browser/api/hid/hid_api.cc - Issue 2656013005: Better crash stacktraces for ExtensionFunction bad messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/hid/hid_api.cc

Issue 2656013005: Better crash stacktraces for ExtensionFunction bad messages. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/hid/hid_api.cc

diff --git a/extensions/browser/api/hid/hid_api.cc b/extensions/browser/api/hid/hid_api.cc

index 48e0ac8dd4de797e2d91ecaa475aa09bb2b805c9..cbddbdec21f414324a8e11a44ce7fec80900653f 100644

--- a/extensions/browser/api/hid/hid_api.cc

+++ b/extensions/browser/api/hid/hid_api.cc

@@ -35,7 +35,7 @@

#define EXTENSION_FUNCTION_VALIDATE_RETURN_FALSE_ON_ERROR(test) \

do { \

if (!(test)) { \

- this->set_bad_message(true); \

+ this->SetBadMessage(); \

return false; \

} \

} while (0)