blink_gc_plugin: retire overloaded traceImpl detection and handling.

tools/clang/blink_gc_plugin/Config.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file defines the names used by GC infrastructure.
 
 // TODO: Restructure the name determination to use fully qualified names (ala,
 // blink::Foo) so that the plugin can be enabled for all of chromium. Doing so
 // would allow us to catch errors with structures outside of blink that might
 // have unsafe pointers to GC allocated blink structures.
 
 #ifndef TOOLS_BLINK_GC_PLUGIN_CONFIG_H_
 #define TOOLS_BLINK_GC_PLUGIN_CONFIG_H_
 
 #include <cassert>
 
 #include "clang/AST/AST.h"
 #include "clang/AST/Attr.h"
 
 extern const char kNewOperatorName[];
 extern const char* kCreateName;
 extern const char* kTraceName;
-extern const char* kTraceImplName;
 extern const char* kFinalizeName;
 extern const char* kTraceAfterDispatchName;
-extern const char* kTraceAfterDispatchImplName;
 extern const char* kRegisterWeakMembersName;
 extern const char kHeapAllocatorName[];
 extern const char kTraceIfNeededName[];
 extern const char kVisitorDispatcherName[];
 extern const char kVisitorVarName[];
 extern const char* kAdjustAndMarkName;
 extern const char* kIsHeapObjectAliveName;
 extern const char kIsEagerlyFinalizedName[];
 extern const char kConstIteratorName[];
 extern const char kIteratorName[];
@@ skipping 175 matching lines @@
       }
     }
 
     return IsVisitorPtrType(formal_type);
   }
 
   enum TraceMethodType {
     NOT_TRACE_METHOD,
     TRACE_METHOD,
     TRACE_AFTER_DISPATCH_METHOD,
-    TRACE_IMPL_METHOD,
-    TRACE_AFTER_DISPATCH_IMPL_METHOD
   };
 
   static TraceMethodType GetTraceMethodType(const clang::FunctionDecl* method) {
     if (method->getNumParams() != 1)
       return NOT_TRACE_METHOD;
 
     const std::string& name = method->getNameAsString();
-    if (name != kTraceName && name != kTraceAfterDispatchName &&
-        name != kTraceImplName && name != kTraceAfterDispatchImplName)
+    if (name != kTraceName && name != kTraceAfterDispatchName)
       return NOT_TRACE_METHOD;
 
     const clang::QualType& formal_type = method->getParamDecl(0)->getType();
-    if (name == kTraceImplName || name == kTraceAfterDispatchImplName) {
-      if (!IsVisitorDispatcherType(formal_type))
-        return NOT_TRACE_METHOD;
-    } else if (!IsVisitorPtrType(formal_type)) {
+    if (!IsVisitorPtrType(formal_type)) {
       return NOT_TRACE_METHOD;
     }
 
     if (name == kTraceName)
       return TRACE_METHOD;
     if (name == kTraceAfterDispatchName)
       return TRACE_AFTER_DISPATCH_METHOD;
-    if (name == kTraceImplName)
-      return TRACE_IMPL_METHOD;
-    if (name == kTraceAfterDispatchImplName)
-      return TRACE_AFTER_DISPATCH_IMPL_METHOD;
 
     assert(false && "Should not reach here");
     return NOT_TRACE_METHOD;
   }
 
   static bool IsTraceMethod(const clang::FunctionDecl* method) {
     return GetTraceMethodType(method) != NOT_TRACE_METHOD;
   }
 
-  static bool IsTraceImplName(const std::string& name) {
-    return name == kTraceImplName || name == kTraceAfterDispatchImplName;
-  }
-
   static bool StartsWith(const std::string& str, const std::string& prefix) {
     if (prefix.size() > str.size())
       return false;
     return str.compare(0, prefix.size(), prefix) == 0;
   }
 
   static bool EndsWith(const std::string& str, const std::string& suffix) {
     if (suffix.size() > str.size())
       return false;
     return str.compare(str.size() - suffix.size(), suffix.size(), suffix) == 0;
   }
 
   // Test if a template specialization is an instantiation.
   static bool IsTemplateInstantiation(clang::CXXRecordDecl* record);
 };
 
 #endif  // TOOLS_BLINK_GC_PLUGIN_CONFIG_H_