src/d8.cc - Issue 265593002: Add v8::Message::GetScriptOrigin() with tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/d8.cc

Issue 265593002: Add v8::Message::GetScriptOrigin() with tests (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/d8.cc

diff --git a/src/d8.cc b/src/d8.cc

index 03356e15a0001819b0865b6854d51d933eb51457..54a3e203a1fb54d61236f4107658002cfe26097a 100644

--- a/src/d8.cc

+++ b/src/d8.cc

@@ -552,7 +552,7 @@ void Shell::ReportException(Isolate* isolate, v8::TryCatch* try_catch) {

printf("%s\n", exception_string);

} else {

// Print (filename):(line number): (message).

- v8::String::Utf8Value filename(message->GetScriptResourceName());

+ v8::String::Utf8Value filename(message->GetScriptOrigin().ResourceName());

const char* filename_string = ToCString(filename);

int linenum = message->GetLineNumber();

printf("%s:%i: %s\n", filename_string, linenum, exception_string);

« no previous file with comments | « src/api.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »