Add v8::Message::GetScriptOrigin() with tests

test/cctest/test-api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 17663 matching lines @@
   i::ScopedVector<char> code(1024);
   i::OS::SNPrintF(code, source, "//# sourceURL=source_url");
   v8::TryCatch try_catch;
   CompileRunWithOrigin(code.start(), "", 0, 0);
   CHECK(try_catch.HasCaught());
   v8::String::Utf8Value stack(try_catch.StackTrace());
   CHECK(strstr(*stack, "at foo (source_url:3:5)") != NULL);
 }
 
 
+TEST(EvalWithSourceURLInStackTraceString) {
+  LocalContext context;
+  v8::HandleScope scope(context->GetIsolate());
+
+  const char *source =
+    "function outer() {\n"
+    "  var scriptContents = \"function foo() { FAIL.FAIL; } "
+    "//# sourceURL=foo2.js\";\n"

[vsevik, 2014/04/30 10:18:40]

could you please break this string (e.g.
"//# source"
"URL=foo2.js\";\n"
To make sure we don't have any possible false sourceURL matches.

[kozyatinskiy1, 2014/04/30 15:46:43]

Done.

+    "  eval(scriptContents); \n"
+    "  foo(); }\n"
+    "outer();\n";
+
+  v8::TryCatch try_catch;
+  CompileRun(source);
+  CHECK(try_catch.HasCaught());
+  v8::String::Utf8Value stack(try_catch.StackTrace());

[vsevik, 2014/04/30 10:18:40]

StackTrace does not use your new method, so this test is not actually testing
it. (Try running it without your patch applied)
You should check that
 try_catch->Message()->GetScriptResourceNameOrSourceURL(); 
returns correct value instead.

Also could you please add a sourceURL comment (with different URL) to the whole
script as well so that we could clearly see that the value returned matches the
inner script.

+  CHECK(strstr(*stack, "at foo (foo2.js:1:18)") != NULL);
+}
+
+
+TEST(RecursionWithSourceURLInStackTraceString) {
+  LocalContext context;
+  v8::HandleScope scope(context->GetIsolate());
+
+  const char *source =
+    "function outer() {\n"
+    "  var scriptContents = \"function boo(){ boo(); }"
+    " function foo() { boo(); } //# sourceURL=foo2.js\";\n"
+    "  eval(scriptContents);\n"
+    "  foo(); }\n"
+    "outer();\n";
+
+  v8::TryCatch try_catch;
+  CompileRun(source);
+  CHECK(try_catch.HasCaught());
+  v8::String::Utf8Value stack(try_catch.StackTrace());

[vsevik, 2014/04/30 10:18:40]

ditto

[kozyatinskiy1, 2014/04/30 15:46:43]

Done.

+  CHECK(strstr(*stack, "at boo (foo2.js:1:13)") != NULL);
+}
+
+
 static void CreateGarbageInOldSpace() {
   i::Factory* factory = CcTest::i_isolate()->factory();
   v8::HandleScope scope(CcTest::isolate());
   i::AlwaysAllocateScope always_allocate(CcTest::i_isolate());
   for (int i = 0; i < 1000; i++) {
     factory->NewFixedArray(1000, i::TENURED);
   }
 }
 
 
@@ skipping 4792 matching lines @@
   v8::internal::FLAG_stack_size = 150;
   LocalContext current;
   v8::Isolate* isolate = current->GetIsolate();
   v8::HandleScope scope(isolate);
   V8::SetCaptureStackTraceForUncaughtExceptions(
       true, 10, v8::StackTrace::kDetailed);
   v8::TryCatch try_catch;
   CompileRun("(function f(x) { f(x+1); })(0)");
   CHECK(try_catch.HasCaught());
 }