Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: content/public/test/test_frame_navigation_observer.h

Issue 2655893004: Convert TestFrameNavigationObserver to use the new navigation callbacks. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/test_frame_navigation_observer.h
diff --git a/content/public/test/test_frame_navigation_observer.h b/content/public/test/test_frame_navigation_observer.h
index aadc9d7e989b2def885e0528ed3cb52f8d00ff16..928801e99b72c6b8910aa6681bf996bd713c2546 100644
--- a/content/public/test/test_frame_navigation_observer.h
+++ b/content/public/test/test_frame_navigation_observer.h
@@ -5,21 +5,12 @@
#ifndef CONTENT_TEST_TEST_FRAME_NAVIGATION_OBSERVER_H_
#define CONTENT_TEST_TEST_FRAME_NAVIGATION_OBSERVER_H_
-#include <memory>
-#include <set>
-
-#include "base/callback.h"
-#include "base/compiler_specific.h"
#include "base/macros.h"
#include "base/run_loop.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/test/browser_test_utils.h"
-#include "content/public/test/test_utils.h"
-
-class GURL;
namespace content {
-class RenderFrameHost;
// Helper for waiting until the navigation in a specific frame tree node (and
// all of its subframes) has completed loading.
@@ -43,13 +34,8 @@ class TestFrameNavigationObserver : public WebContentsObserver {
private:
// WebContentsObserver
- void DidStartProvisionalLoadForFrame(RenderFrameHost* render_frame_host,
- const GURL& validated_url,
- bool is_error_page) override;
- void DidCommitProvisionalLoadForFrame(
- RenderFrameHost* render_frame_host,
- const GURL& url,
- ui::PageTransition transition_type) override;
+ void DidStartNavigation(NavigationHandle* navigation_handle) override;
+ void DidFinishNavigation(NavigationHandle* navigation_handle) override;
void DidStopLoading() override;
// The id of the FrameTreeNode in which navigations are peformed.

Powered by Google App Engine
This is Rietveld 408576698