components/policy/core/browser/cloud/message_util.cc - Issue 2655873002: Get enrollment token from DMServer when an Active Directory user uses ARC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/browser/cloud/message_util.cc

Issue 2655873002: Get enrollment token from DMServer when an Active Directory user uses ARC (Closed)

Patch Set: Fix Thiemo's comments, add browsertest for arc_active_directory_enrollment_token_fetcher Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/policy/core/browser/cloud/message_util.cc

diff --git a/components/policy/core/browser/cloud/message_util.cc b/components/policy/core/browser/cloud/message_util.cc

index 2292b5b7b007bd5c4f76edae2da1475f36bf8ad7..582966ac9a16943d1e4f2c8cd1d6357403504220 100644

--- a/components/policy/core/browser/cloud/message_util.cc

+++ b/components/policy/core/browser/cloud/message_util.cc

@@ -48,6 +48,8 @@ int GetIDSForDMStatus(DeviceManagementStatus status) {

return IDS_POLICY_DM_STATUS_SERVICE_POLICY_NOT_FOUND;

case DM_STATUS_CANNOT_SIGN_REQUEST:

return IDS_POLICY_DM_STATUS_CANNOT_SIGN_REQUEST;

+ case DM_STATUS_SERVICE_ARC_DISABLED:

+ return IDS_POLICY_DM_STATUS_UNKNOWN_ERROR;

Thiemo Nagel 2017/02/03 12:45:49 Nit: I'd suggest to add a comment that the ARC_DIS

Marton Hunyady 2017/02/03 13:23:25 Done.

}

NOTREACHED() << "Unhandled DM status " << status;

return IDS_POLICY_DM_STATUS_UNKNOWN_ERROR;