chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc - Issue 2655873002: Get enrollment token from DMServer when an Active Directory user uses ARC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc

Issue 2655873002: Get enrollment token from DMServer when an Active Directory user uses ARC (Closed)

Patch Set: Change error message string Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/arc/auth/arc_robot_auth_code_fetcher.h ('k') | components/arc/common/auth.mojom » ('j') | components/policy/core/browser/cloud/message_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc

diff --git a/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc b/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc

index a7495932aec90e8618c9f6dc81cd075517f223c7..716ceb0c572d9f975d184fab6ff723bb2f1643d5 100644

--- a/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc

+++ b/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc

@@ -357,6 +357,9 @@ void EnterpriseEnrollmentHelperImpl::ReportEnrollmentStatus(

break;

case policy::DM_STATUS_CANNOT_SIGN_REQUEST:

UMA(policy::kMetricEnrollmentRegisterCannotSignRequest);

+ break;

+ case policy::DM_STATUS_SERVICE_ARC_DISABLED:

Thiemo Nagel 2017/02/02 13:24:59 I think that should be NOTREACHED instead. (And p

Marton Hunyady 2017/02/02 18:19:06 Done.

+ UMA(policy::kMetricEnrollmentArcDisabled);

}

break;

case policy::EnrollmentStatus::REGISTRATION_BAD_MODE: