Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Unified Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 2655853010: [TypeFeedbackVector] Combine the literals array and the feedback vector. (Closed)
Patch Set: more comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen/mips64/full-codegen-mips64.cc ('k') | src/heap/heap.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/full-codegen/x64/full-codegen-x64.cc
diff --git a/src/full-codegen/x64/full-codegen-x64.cc b/src/full-codegen/x64/full-codegen-x64.cc
index 56fe0112cca4f3678ad573a95c7ab13197996315..f66f99a9e641c2c22db8274bc7dc51cc71909edc 100644
--- a/src/full-codegen/x64/full-codegen-x64.cc
+++ b/src/full-codegen/x64/full-codegen-x64.cc
@@ -121,8 +121,7 @@ void FullCodeGenerator::Generate() {
// Increment invocation count for the function.
{
Comment cmnt(masm_, "[ Increment invocation count");
- __ movp(rcx, FieldOperand(rdi, JSFunction::kLiteralsOffset));
- __ movp(rcx, FieldOperand(rcx, LiteralsArray::kFeedbackVectorOffset));
+ __ movp(rcx, FieldOperand(rdi, JSFunction::kFeedbackVectorOffset));
__ SmiAddConstant(
FieldOperand(rcx,
TypeFeedbackVector::kInvocationCountIndex * kPointerSize +
@@ -1175,13 +1174,13 @@ void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {
int flags = expr->ComputeFlags();
if (MustCreateObjectLiteralWithRuntime(expr)) {
__ Push(Operand(rbp, JavaScriptFrameConstants::kFunctionOffset));
- __ Push(Smi::FromInt(expr->literal_index()));
+ __ Push(SmiFromSlot(expr->literal_slot()));
__ Push(constant_properties);
__ Push(Smi::FromInt(flags));
__ CallRuntime(Runtime::kCreateObjectLiteral);
} else {
__ movp(rax, Operand(rbp, JavaScriptFrameConstants::kFunctionOffset));
- __ Move(rbx, Smi::FromInt(expr->literal_index()));
+ __ Move(rbx, SmiFromSlot(expr->literal_slot()));
__ Move(rcx, constant_properties);
__ Move(rdx, Smi::FromInt(flags));
Callable callable = CodeFactory::FastCloneShallowObject(
@@ -1311,13 +1310,13 @@ void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) {
if (MustCreateArrayLiteralWithRuntime(expr)) {
__ Push(Operand(rbp, JavaScriptFrameConstants::kFunctionOffset));
- __ Push(Smi::FromInt(expr->literal_index()));
+ __ Push(SmiFromSlot(expr->literal_slot()));
__ Push(constant_elements);
__ Push(Smi::FromInt(expr->ComputeFlags()));
__ CallRuntime(Runtime::kCreateArrayLiteral);
} else {
__ movp(rax, Operand(rbp, JavaScriptFrameConstants::kFunctionOffset));
- __ Move(rbx, Smi::FromInt(expr->literal_index()));
+ __ Move(rbx, SmiFromSlot(expr->literal_slot()));
__ Move(rcx, constant_elements);
Callable callable =
CodeFactory::FastCloneShallowArray(isolate(), allocation_site_mode);
« no previous file with comments | « src/full-codegen/mips64/full-codegen-mips64.cc ('k') | src/heap/heap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698