Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: src/debug/liveedit.cc

Issue 2655853010: [TypeFeedbackVector] Combine the literals array and the feedback vector. (Closed)
Patch Set: more comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/hydrogen-instructions.h ('k') | src/deoptimizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/liveedit.cc
diff --git a/src/debug/liveedit.cc b/src/debug/liveedit.cc
index 06b4b883ae93d6e3a5ff8c7bec52705668232dfb..fe0d0c5a3976a4be6b2aa02c1f85ca07b9c3b7fc 100644
--- a/src/debug/liveedit.cc
+++ b/src/debug/liveedit.cc
@@ -774,9 +774,7 @@ class LiteralFixer {
Handle<JSFunction> fun(JSFunction::cast(function_instances->get(i)));
Handle<TypeFeedbackVector> vector =
TypeFeedbackVector::New(isolate, feedback_metadata);
- Handle<LiteralsArray> new_literals =
- LiteralsArray::New(isolate, vector, new_literal_count);
- fun->set_literals(*new_literals);
+ fun->set_feedback_vector(*vector);
}
shared_info->set_num_literals(new_literal_count);
@@ -821,11 +819,8 @@ class LiteralFixer {
class ClearValuesVisitor {
public:
void visit(JSFunction* fun) {
- LiteralsArray* literals = fun->literals();
- int len = literals->literals_count();
- for (int j = 0; j < len; j++) {
- literals->set_literal_undefined(j);
- }
+ TypeFeedbackVector* vector = fun->feedback_vector();
+ vector->ClearSlots(fun->shared());
}
};
« no previous file with comments | « src/crankshaft/hydrogen-instructions.h ('k') | src/deoptimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698