Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/profiler/heap-snapshot-generator.cc

Issue 2655853010: [TypeFeedbackVector] Combine the literals array and the feedback vector. (Closed)
Patch Set: more comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/parsing/preparser.h ('k') | src/runtime/runtime-literals.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/profiler/heap-snapshot-generator.h" 5 #include "src/profiler/heap-snapshot-generator.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/conversions.h" 10 #include "src/conversions.h"
(...skipping 1094 matching lines...) Expand 10 before | Expand all | Expand 10 after
1105 } else { 1105 } else {
1106 SetPropertyReference( 1106 SetPropertyReference(
1107 obj, entry, 1107 obj, entry,
1108 heap_->prototype_string(), js_fun->prototype()); 1108 heap_->prototype_string(), js_fun->prototype());
1109 SetInternalReference( 1109 SetInternalReference(
1110 obj, entry, "initial_map", proto_or_map, 1110 obj, entry, "initial_map", proto_or_map,
1111 JSFunction::kPrototypeOrInitialMapOffset); 1111 JSFunction::kPrototypeOrInitialMapOffset);
1112 } 1112 }
1113 } 1113 }
1114 SharedFunctionInfo* shared_info = js_fun->shared(); 1114 SharedFunctionInfo* shared_info = js_fun->shared();
1115 TagObject(js_fun->literals(), "(function literals)"); 1115 TagObject(js_fun->feedback_vector(), "(function feedback vector)");
1116 SetInternalReference(js_fun, entry, "literals", js_fun->literals(), 1116 SetInternalReference(js_fun, entry, "feedback_vector",
1117 JSFunction::kLiteralsOffset); 1117 js_fun->feedback_vector(),
1118 JSFunction::kFeedbackVectorOffset);
1118 TagObject(shared_info, "(shared function info)"); 1119 TagObject(shared_info, "(shared function info)");
1119 SetInternalReference(js_fun, entry, 1120 SetInternalReference(js_fun, entry,
1120 "shared", shared_info, 1121 "shared", shared_info,
1121 JSFunction::kSharedFunctionInfoOffset); 1122 JSFunction::kSharedFunctionInfoOffset);
1122 TagObject(js_fun->context(), "(context)"); 1123 TagObject(js_fun->context(), "(context)");
1123 SetInternalReference(js_fun, entry, 1124 SetInternalReference(js_fun, entry,
1124 "context", js_fun->context(), 1125 "context", js_fun->context(),
1125 JSFunction::kContextOffset); 1126 JSFunction::kContextOffset);
1126 // Ensure no new weak references appeared in JSFunction. 1127 // Ensure no new weak references appeared in JSFunction.
1127 STATIC_ASSERT(JSFunction::kCodeEntryOffset == 1128 STATIC_ASSERT(JSFunction::kCodeEntryOffset ==
(...skipping 1986 matching lines...) Expand 10 before | Expand all | Expand 10 after
3114 for (int i = 1; i < sorted_strings.length(); ++i) { 3115 for (int i = 1; i < sorted_strings.length(); ++i) {
3115 writer_->AddCharacter(','); 3116 writer_->AddCharacter(',');
3116 SerializeString(sorted_strings[i]); 3117 SerializeString(sorted_strings[i]);
3117 if (writer_->aborted()) return; 3118 if (writer_->aborted()) return;
3118 } 3119 }
3119 } 3120 }
3120 3121
3121 3122
3122 } // namespace internal 3123 } // namespace internal
3123 } // namespace v8 3124 } // namespace v8
OLDNEW
« no previous file with comments | « src/parsing/preparser.h ('k') | src/runtime/runtime-literals.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698