third_party/WebKit/Source/wtf/text/WTFStringTest.cpp - Issue 2655853003: Replace StringImpl::empty{16Bit}() with a static member

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/WTFStringTest.cpp

Issue 2655853003: Replace StringImpl::empty{16Bit}() with a static member (Closed)

Patch Set: annotate race Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/WTFStringTest.cpp

diff --git a/third_party/WebKit/Source/wtf/text/WTFStringTest.cpp b/third_party/WebKit/Source/wtf/text/WTFStringTest.cpp

index 0f6c640f02457f66192b1c8794904c821b380d0e..b8adf4972f082cf86e7aa7bd79a883fda47dd305 100644

--- a/third_party/WebKit/Source/wtf/text/WTFStringTest.cpp

+++ b/third_party/WebKit/Source/wtf/text/WTFStringTest.cpp

@@ -445,14 +445,14 @@ TEST(StringTest, Ensure16Bit) {

EXPECT_FALSE(string16.is8Bit());

EXPECT_EQ("16bit", string16);

- String empty8(StringImpl::empty());

+ String empty8(StringImpl::empty);

EXPECT_TRUE(empty8.is8Bit());

empty8.ensure16Bit();

EXPECT_FALSE(empty8.is8Bit());

EXPECT_TRUE(empty8.isEmpty());

EXPECT_FALSE(empty8.isNull());

- String empty16(StringImpl::empty16Bit());

+ String empty16(StringImpl::empty16Bit);

EXPECT_FALSE(empty16.is8Bit());

empty16.ensure16Bit();

EXPECT_FALSE(empty16.is8Bit());

« no previous file with comments | « third_party/WebKit/Source/wtf/text/WTFString.cpp ('k') | no next file » | no next file with comments »