Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: third_party/WebKit/Source/wtf/text/StringImpl.h

Issue 2655853003: Replace StringImpl::empty{16Bit}() with a static member (Closed)
Patch Set: annotate race Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/wtf/text/StringImpl.h
diff --git a/third_party/WebKit/Source/wtf/text/StringImpl.h b/third_party/WebKit/Source/wtf/text/StringImpl.h
index 77dfcc38d5f07621d4ee90d8cedea8e0c8425cc0..afdb6af132ebe2f62d4e824de43a744f48eccde6 100644
--- a/third_party/WebKit/Source/wtf/text/StringImpl.h
+++ b/third_party/WebKit/Source/wtf/text/StringImpl.h
@@ -205,8 +205,13 @@ class WTF_EXPORT StringImpl {
m_isStatic(true) {}
public:
+ static StringImpl* empty;
+ static StringImpl* empty16Bit;
+
~StringImpl();
+ static void initStatics();
+
static StringImpl* createStatic(const char* string,
unsigned length,
unsigned hash);
@@ -324,9 +329,6 @@ class WTF_EXPORT StringImpl {
destroyIfNotStatic();
}
- static StringImpl* empty();
- static StringImpl* empty16Bit();
-
// FIXME: Does this really belong in StringImpl?
template <typename T>
static void copyChars(T* destination,
« no previous file with comments | « third_party/WebKit/Source/wtf/text/AtomicStringTable.cpp ('k') | third_party/WebKit/Source/wtf/text/StringImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698