third_party/WebKit/Source/wtf/ThreadingPthreads.cpp - Issue 2655853003: Replace StringImpl::empty{16Bit}() with a static member

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/ThreadingPthreads.cpp

Issue 2655853003: Replace StringImpl::empty{16Bit}() with a static member (Closed)

Patch Set: annotate race Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/ThreadingPthreads.cpp

diff --git a/third_party/WebKit/Source/wtf/ThreadingPthreads.cpp b/third_party/WebKit/Source/wtf/ThreadingPthreads.cpp

index 886e661c2aa6746139444527a8e0eedf72156e33..6120cb6a6fff3acfdee5f606b1c79ead318e4a3e 100644

--- a/third_party/WebKit/Source/wtf/ThreadingPthreads.cpp

+++ b/third_party/WebKit/Source/wtf/ThreadingPthreads.cpp

@@ -81,10 +81,6 @@ void initializeThreading() {

// This should only be called once.

DCHECK(!atomicallyInitializedStaticMutex);

- // StringImpl::empty() does not construct its static string in a threadsafe

- // fashion, so ensure it has been initialized from here.

- StringImpl::empty();

- StringImpl::empty16Bit();

atomicallyInitializedStaticMutex = new Mutex;

wtfThreadData();

initializeDates();