Replace StringImpl::empty{16Bit}() with a static member

third_party/WebKit/Source/wtf/text/WTFString.cpp

Index: third_party/WebKit/Source/wtf/text/WTFString.cpp
diff --git a/third_party/WebKit/Source/wtf/text/WTFString.cpp b/third_party/WebKit/Source/wtf/text/WTFString.cpp
index 0cfe47326d65f40620f44f709acac7a528ad8d3e..734f396c21591f01783de4b54d642d70880c790c 100644
--- a/third_party/WebKit/Source/wtf/text/WTFString.cpp
+++ b/third_party/WebKit/Source/wtf/text/WTFString.cpp
@@ -260,7 +260,7 @@ void String::ensure16Bit() {
     m_impl =
         make16BitFrom8BitSource(m_impl->characters8(), length).releaseImpl();
   else
-    m_impl = StringImpl::empty16Bit();
+    m_impl = StringImpl::empty16Bit;
 }
 
 void String::truncate(unsigned length) {
@@ -785,12 +785,12 @@ String String::fromUTF8WithLatin1Fallback(const LChar* string, size_t size) {
 }
 
 const String& emptyString() {
-  DEFINE_STATIC_LOCAL(String, emptyString, (StringImpl::empty()));
+  DEFINE_STATIC_LOCAL(String, emptyString, (StringImpl::empty));
   return emptyString;

[esprehn, 2017/02/01 05:23:44]

We should probably make these statics too.

[Charlie Harrison, 2017/02/01 05:29:48]

Yeah I can probably do another patch for this, but there are a *lot* more
callers so the patch will be intense (unless we do something weird like inline
the function).

[esprehn, 2017/02/01 05:47:39]

That seems like a reasonable thing to do. Add String::empty and then make the
function inline and just return it. Add a TODO to clean up the tons of callers.
Then someone motivated (maybe you later) can clean it up.

 }
 
 const String& emptyString16Bit() {
-  DEFINE_STATIC_LOCAL(String, emptyString, (StringImpl::empty16Bit()));
+  DEFINE_STATIC_LOCAL(String, emptyString, (StringImpl::empty16Bit));
   return emptyString;
 }