Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2655843003: Further decouple KernelImpactBuilder from elements (Closed)

Created:
3 years, 11 months ago by Johnni Winther
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : dartfmt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -19 lines) Patch
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 1 7 chunks +14 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 11 months ago (2017-01-25 10:45:02 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 11 months ago (2017-01-25 16:37:57 UTC) #3
Johnni Winther
3 years, 11 months ago (2017-01-26 09:24:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d2645e2ffd7814cabf0abeae38b0af3e21d3a1f3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698