Expand _AssertionError._evaluateAssertion in the frontend

Expand _AssertionError._evaluateAssertion in the frontend

The call in _evaluationAssertion becomes megamorphic and this is
showing up on Flutter's profile. Avoid the call becoming megamorphic
by inlining the body at the AST level.

BUG=
R=hausner@google.com

Committed: https://github.com/dart-lang/sdk/commit/9779ff264a7828ea336382b3a5654898206fe462

[Cutch, 2017-01-26 19:24:41]

Description was changed from

==========
Expand _AssertionError._evaluateAssertion in the frontend

The call in _evaluationAssertion becomes megamorphic and this is
showing up on Flutter's profile. Avoid the call becoming megamorphic
by inlining the body at the AST level.

BUG=
==========

to

==========
Expand _AssertionError._evaluateAssertion in the frontend

The call in _evaluationAssertion becomes megamorphic and this is
showing up on Flutter's profile. Avoid the call becoming megamorphic
by inlining the body at the AST level.

BUG=
==========

[Cutch, 2017-01-26 19:24:41]

johnmccutchan@google.com changed reviewers:
+ fschneider@google.com, hausner@google.com

[hausner, 2017-01-26 20:41:13]

LGTM w/comment

https://codereview.chromium.org/2655803007/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (left):

https://codereview.chromium.org/2655803007/diff/1/runtime/vm/parser.cc#oldcod...
runtime/vm/parser.cc:9257:
Library::PrivateCoreLibName(Symbols::EvaluateAssertion()), arguments);
The EvaluateAssertion function is now probably dead code, and the symbol is no
longer needed. If so, please remove it.

https://codereview.chromium.org/2655803007/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2655803007/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:9252: LetNode* condition_or_condition_after_invoke =
Maybe add a comment here to document the code that is generated:
temp = condition;
condition = (temp is Function) ? temp() : temp;

[Cutch, 2017-02-01 17:15:35]

PTAL

https://codereview.chromium.org/2655803007/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (left):

https://codereview.chromium.org/2655803007/diff/1/runtime/vm/parser.cc#oldcod...
runtime/vm/parser.cc:9257:
Library::PrivateCoreLibName(Symbols::EvaluateAssertion()), arguments);
On 2017/01/26 20:41:13, hausner wrote:
> The EvaluateAssertion function is now probably dead code, and the symbol is no
> longer needed. If so, please remove it.

I've changed the code to not always inline the code so it is no longer dead.

https://codereview.chromium.org/2655803007/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2655803007/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:9252: LetNode* condition_or_condition_after_invoke =
On 2017/01/26 20:41:13, hausner wrote:
> Maybe add a comment here to document the code that is generated:
> temp = condition;
> condition = (temp is Function) ? temp() : temp;

Done.

[hausner, 2017-02-01 17:40:13]

Very nice and simple. LGTM.

[Cutch, 2017-02-02 15:34:40]

Description was changed from

==========
Expand _AssertionError._evaluateAssertion in the frontend

The call in _evaluationAssertion becomes megamorphic and this is
showing up on Flutter's profile. Avoid the call becoming megamorphic
by inlining the body at the AST level.

BUG=
==========

to

==========
Expand _AssertionError._evaluateAssertion in the frontend

The call in _evaluationAssertion becomes megamorphic and this is
showing up on Flutter's profile. Avoid the call becoming megamorphic
by inlining the body at the AST level.

BUG=
R=hausner@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9779ff264a7828ea336382b3a5654898206fe462
==========

[Cutch, 2017-02-02 15:34:42]

Committed patchset #4 (id:60001) manually as
9779ff264a7828ea336382b3a5654898206fe462 (presubmit successful).