Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: chrome/browser/spellchecker/spellcheck_service.cc

Issue 26558006: [spell] Remove spelling service feedback from behind the flag (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Correct number of seconds Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/spellchecker/spellcheck_service.h ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/spellchecker/spellcheck_service.cc
diff --git a/chrome/browser/spellchecker/spellcheck_service.cc b/chrome/browser/spellchecker/spellcheck_service.cc
index 848dfc7c72e1ccba819f45479df5cda8bc578529..2bb13aebe3f747f25e292106606dee5dbc40e1bf 100644
--- a/chrome/browser/spellchecker/spellcheck_service.cc
+++ b/chrome/browser/spellchecker/spellcheck_service.cc
@@ -13,6 +13,7 @@
#include "chrome/browser/spellchecker/spellcheck_host_metrics.h"
#include "chrome/browser/spellchecker/spellcheck_hunspell_dictionary.h"
#include "chrome/browser/spellchecker/spellcheck_platform_mac.h"
+#include "chrome/browser/spellchecker/spelling_service_client.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/spellcheck_messages.h"
#include "components/user_prefs/user_prefs.h"
@@ -307,6 +308,7 @@ void SpellcheckService::OnSpellCheckDictionaryChanged() {
chrome::spellcheck_common::GetISOLanguageCountryCodeFromLocale(
dictionary, &language_code, &country_code);
feedback_sender_->OnLanguageCountryChange(language_code, country_code);
+ UpdateFeedbackSenderState();
}
void SpellcheckService::OnUseSpellingServiceChanged() {
@@ -314,4 +316,14 @@ void SpellcheckService::OnUseSpellingServiceChanged() {
prefs::kSpellCheckUseSpellingService);
if (metrics_)
metrics_->RecordSpellingServiceStats(enabled);
+ UpdateFeedbackSenderState();
+}
+
+void SpellcheckService::UpdateFeedbackSenderState() {
+ if (SpellingServiceClient::IsAvailable(
+ context_, SpellingServiceClient::SPELLCHECK)) {
+ feedback_sender_->StartFeedbackCollection();
+ } else {
+ feedback_sender_->StopFeedbackCollection();
+ }
}
« no previous file with comments | « chrome/browser/spellchecker/spellcheck_service.h ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698