Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 26558002: Remove unncessary Scrollbar.h include which will allow me to move all of ScrollbarTheme* to Source/… (Closed)

Created:
7 years, 2 months ago by atreat
Modified:
7 years, 2 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, do-not-use
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Remove unncessary Scrollbar.h include which will allow me to move all of ScrollbarTheme* to Source/platform BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159238

Patch Set 1 #

Patch Set 2 : Rebase to apply cleanly on trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M Source/core/platform/ScrollbarThemeAuraOrGtk.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/ScrollbarThemeNonMacCommon.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/ScrollbarThemeOverlay.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/ScrollbarThemeWin.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
atreat
Last step before I can move the bulk of ScrollbarTheme* to Source/platform/scroll
7 years, 2 months ago (2013-10-08 19:01:35 UTC) #1
abarth-chromium
lgtm
7 years, 2 months ago (2013-10-08 19:19:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/26558002/1
7 years, 2 months ago (2013-10-09 02:44:55 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/core/platform/ScrollbarThemeWin.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 2 months ago (2013-10-09 02:44:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/26558002/6001
7 years, 2 months ago (2013-10-09 14:04:40 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-09 16:00:46 UTC) #6
Message was sent while issue was closed.
Change committed as 159238

Powered by Google App Engine
This is Rietveld 408576698