Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.cc

Issue 2655783006: Top down version of algorithm to position margins and floats in LayoutNG (Closed)
Patch Set: git rebase-update Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.cc b/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.cc
index 8efd4f90a26a0ac8858ea971646e128b2ee7a76d..845b55fb7429b0b769db1241155bd6b2b53be948 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.cc
@@ -13,9 +13,10 @@ NGPhysicalBoxFragment::NGPhysicalBoxFragment(
HeapVector<Member<NGPhysicalFragment>>& children,
HeapLinkedHashSet<WeakMember<NGBlockNode>>& out_of_flow_descendants,
Vector<NGStaticPosition>& out_of_flow_positions,
- NGDeprecatedMarginStrut margin_strut,
HeapVector<Member<NGFloatingObject>>& unpositioned_floats,
HeapVector<Member<NGFloatingObject>>& positioned_floats,
+ const WTF::Optional<NGLogicalOffset>& bfc_offset,
+ const NGMarginStrut& end_margin_strut,
NGBreakToken* break_token)
: NGPhysicalFragment(layout_object,
size,
@@ -26,7 +27,8 @@ NGPhysicalBoxFragment::NGPhysicalBoxFragment(
unpositioned_floats,
positioned_floats,
break_token),
- margin_strut_(margin_strut) {
+ bfc_offset_(bfc_offset),
+ end_margin_strut_(end_margin_strut) {
children_.swap(children);
}

Powered by Google App Engine
This is Rietveld 408576698