third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h - Issue 2655783006: Top down version of algorithm to position margins and floats in LayoutNG

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h

Issue 2655783006: Top down version of algorithm to position margins and floats in LayoutNG (Closed)

Patch Set: git rebase-update Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h

index 7241c0026473b8a382834b9511ee1dc558d2b65c..d0795238b438027abafe9a5a5e8aafcbbf98b330 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h

@@ -26,12 +26,11 @@ class CORE_EXPORT NGLayoutOpportunityIterator final

// @param space Constraint space with exclusions for which this iterator needs

// to generate layout opportunities.

// @param opt_origin_point Optional origin_point parameter that is used as a

- // default start point for layout opportunities.

+ // default start point for layout opportunities.

// @param opt_leader_point Optional 'leader' parameter that is used to specify

- // the

- // ending point of temporary excluded rectangle which

- // starts from 'origin'. This rectangle may represent a

- // text fragment for example.

+ // the ending point of temporary excluded rectangle

+ // which starts from 'origin'. This rectangle may

+ // represent a text fragment for example.

NGLayoutOpportunityIterator(

NGConstraintSpace* space,

const WTF::Optional<NGLogicalOffset>& opt_origin_point = WTF::nullopt,