Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_floating_object.h

Issue 2655783006: Top down version of algorithm to position margins and floats in LayoutNG (Closed)
Patch Set: git rebase-update Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_floating_object.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_floating_object.h b/third_party/WebKit/Source/core/layout/ng/ng_floating_object.h
index c32a93152c63648b99036ce25c3981c33d749875..68a84315fb779c6785dd21e6f4895525e199adef 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_floating_object.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_floating_object.h
@@ -20,7 +20,7 @@ class NGPhysicalFragment;
struct CORE_EXPORT NGFloatingObject
: public GarbageCollected<NGFloatingObject> {
NGFloatingObject(NGPhysicalFragment* fragment,
- const NGConstraintSpace* space,
+ NGConstraintSpace* space,
NGBlockNode* node,
const ComputedStyle& style,
const NGBoxStrut& margins)
@@ -32,7 +32,8 @@ struct CORE_EXPORT NGFloatingObject
}
Member<NGPhysicalFragment> fragment;
- Member<const NGConstraintSpace> space;
+ // TODO(glebl): Constraint space should be const here.
+ Member<NGConstraintSpace> space;
Member<NGBlockNode> node;
NGExclusion::Type exclusion_type;
EClear clear_type;

Powered by Google App Engine
This is Rietveld 408576698