Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/ng_box_fragment.cc

Issue 2655783006: Top down version of algorithm to position margins and floats in LayoutNG (Closed)
Patch Set: fix comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/layout/ng/ng_box_fragment.h" 5 #include "core/layout/ng/ng_box_fragment.h"
6 6
7 #include "core/layout/ng/ng_macros.h" 7 #include "core/layout/ng/ng_macros.h"
8 #include "core/layout/ng/ng_physical_box_fragment.h" 8 #include "core/layout/ng/ng_physical_box_fragment.h"
9 9
10 namespace blink { 10 namespace blink {
11 11
12 NGDeprecatedMarginStrut NGBoxFragment::MarginStrut() const { 12 const WTF::Optional<NGLogicalOffset>& NGBoxFragment::BfcOffset() const {
13 return toNGPhysicalBoxFragment(physical_fragment_)->BfcOffset();
ikilpatrick 2017/01/30 22:26:49 may want to add a similar WRITING_MODE_IGNORED her
Gleb Lanbin 2017/01/31 00:25:02 Done.
14 }
15
16 const NGMarginStrut& NGBoxFragment::EndMarginStrut() const {
13 WRITING_MODE_IGNORED( 17 WRITING_MODE_IGNORED(
14 "Accessing the margin strut is fine here. Changing the writing mode" 18 "Accessing the margin strut is fine here. Changing the writing mode"
15 "establishes a new formatting context, for which a margin strut is never" 19 "establishes a new formatting context, for which a margin strut is"
16 "set for a fragment."); 20 "never set for a fragment.");
17 return toNGPhysicalBoxFragment(physical_fragment_)->MarginStrut(); 21 return toNGPhysicalBoxFragment(physical_fragment_)->EndMarginStrut();
18 } 22 }
19 23
20 } // namespace blink 24 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698