Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2655713002: Fix prelinker when a local name shadows an import prefix. (Closed)

Created:
3 years, 11 months ago by Paul Berry
Modified:
3 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix prelinker when a local name shadows an import prefix. Fixes #28391. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/1944ff1e6994f06ea4abdf60d308f5037624fe43

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -24 lines) Patch
M pkg/analyzer/lib/src/summary/prelink.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_driver_test.dart View 1 chunk +0 lines, -24 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 11 months ago (2017-01-24 16:53:34 UTC) #2
scheglov
LGTM Thanks!
3 years, 11 months ago (2017-01-24 16:55:35 UTC) #3
Paul Berry
3 years, 11 months ago (2017-01-24 17:02:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1944ff1e6994f06ea4abdf60d308f5037624fe43 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698