Issue 26557002: Fix the preferred logical widths code to work with spanning grid items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26557002: Fix the preferred logical widths code to work with spanning grid items (Closed)

Created:
7 years, 2 months ago by Julien - ping for review

Modified:
7 years, 2 months ago

Reviewers:
ojan

CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, esprehn, eseidel

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix the preferred logical widths code to work with spanning grid items We implemented a simple algorithm to get the easy cases. The algorithm was completely wrong for more complex cases though, which was fine as the specification was completely silent on how to compute these logical widths. This has been raised to the working group in http://lists.w3.org/Archives/Public/www-style/2013Oct/0054.html No one objected after a week so we should be good to go. BUG=234197 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159189

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+59 lines, -45 lines)			Patch
LayoutTests/fast/css-grid-layout/grid-preferred-logical-widths.html	View	3 chunks	+29 lines, -0 lines	0 comments	Download
LayoutTests/fast/css-grid-layout/grid-preferred-logical-widths-expected.txt	View	2 chunks	+16 lines, -0 lines	0 comments	Download
Source/core/rendering/RenderGrid.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
Source/core/rendering/RenderGrid.cpp	View	4 chunks	+13 lines, -43 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/26557002/1

7 years, 2 months ago (2013-10-08 23:07:36 UTC) #3

Message was sent while issue was closed.

Change committed as 159189

Expand Messages | Collapse Messages