Update tests for FF 51

pkg/dev_compiler/test/browser/language_tests.js

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
       function(dart_sdk, async_helper, expect, unittest, is, require) {
   'use strict';
 
   async_helper = async_helper.async_helper;
   let minitest = expect.minitest;
@@ skipping 117 matching lines @@
       'expect_test': fail,
       'extends_test_lib': fail,
       'external_test_10_multi': fail,
       'external_test_13_multi': fail,
       'external_test_20_multi': fail,
       'f_bounded_quantification3_test': fail,
       'field_increment_bailout_test': fail,
       'field_optimization3_test': fail,
       'final_syntax_test_08_multi': fail,
       'first_class_types_test': fail,
-      'for_variable_capture_test': chrome_fail,
+      'for_variable_capture_test': is.firefox('<=50') ? pass : fail,

[vsm, 2017/01/24 16:32:01]

Note, this is the opposite of everything else - it's now failing on chrome and
ff but passing on older ff.  Perhaps a bug in either our code gen or the test?

       'function_subtype0_test': fail,
       'function_subtype1_test': fail,
       'function_subtype2_test': fail,
       'function_subtype3_test': fail,
       'function_subtype_bound_closure0_test': fail,
       'function_subtype_bound_closure1_test': fail,
       'function_subtype_bound_closure2_test': fail,
       'function_subtype_bound_closure3_test': fail,
       'function_subtype_bound_closure4_test': fail,
       'function_subtype_bound_closure5_test': fail,
@@ skipping 66 matching lines @@
       'mixin_mixin4_test': fail,
       'mixin_mixin5_test': fail,
       'mixin_mixin6_test': fail,
       'mixin_mixin7_test': fail,
       'mixin_mixin_bound2_test': fail,
       'mixin_mixin_bound_test': fail,
       'mixin_mixin_test': fail,
       'mixin_regress_13688_test': fail,
       'modulo_test': fail,
       'named_parameter_clash_test': fail,
-      'named_parameters_passing_falsy_test': firefox_fail,
+      'named_parameters_passing_falsy_test': is.firefox('<=50') ? fail : pass,
       'nan_identical_test': fail,
       'nested_switch_label_test': fail,
       'number_identifier_test_05_multi': fail,
       'number_identity2_test': fail,
       'numbers_test': fail,
       'redirecting_factory_reflection_test': fail,
       'regress_16640_test': fail,
       'regress_18535_test': fail,
       'regress_22666_test': fail,
       'regress_22777_test': flaky,
@@ skipping 51 matching lines @@
       'bit_twiddling_bigint_test': fail,
       'collection_length_test': skip_timeout,
       'compare_to2_test': fail,
       'const_list_literal_test': fail,
       'const_list_remove_range_test': fail,
       'const_list_set_range_test': fail,
       'double_parse_test_01_multi': fail,
       'double_parse_test_02_multi': firefox_fail,
       'error_stack_trace1_test': fail,
       'error_stack_trace2_test': fail,
-      'for_in_test': firefox_fail,
+      'for_in_test': is.firefox('<=50') ? fail : pass,
       'hash_map2_test': skip_timeout,
       'hash_set_test_01_multi': fail,
       'hidden_library2_test_01_multi': fail,
       'int_modulo_arith_test_bignum_multi': fail,
       'int_modulo_arith_test_modPow_multi': fail,
       'int_modulo_arith_test_none_multi': fail,
       'int_parse_radix_test_01_multi': fail, // JS implementations disagree on U+0085 being whitespace.
       'int_parse_radix_test_02_multi': ['fail', 'timeout', 'skip'], // No bigints.
       'int_parse_radix_test_none_multi': ['slow'],
       'integer_to_radix_string_test': fail,
       'integer_to_string_test_01_multi': fail,
       'iterable_generate_test': fail,
       'iterable_return_type_test_02_multi': fail,
       'json_map_test': fail,
       'list_fill_range_test': fail,
       'list_replace_range_test': fail,
       'list_set_all_test': fail,
       'list_to_string2_test': fail,
       'main_test': fail,
       'map_keys2_test': fail,
       'map_to_string_test': fail,
-      'map_from_iterable_test': firefox_fail,
+      'map_from_iterable_test': is.firefox('<=50') ? fail : pass,
       'nan_infinity_test_01_multi': fail,
       'null_nosuchmethod_test': fail,
       'null_test': fail,
       'num_sign_test': fail,
       'regress_r21715_test': fail,
       'throw_half_surrogate_pair_test_02_multi': fail,
-      'splay_tree_from_iterable_test': firefox_fail,
+      'splay_tree_from_iterable_test': is.firefox('<=50') ? fail : pass,
       'string_case_test_01_multi': firefox_fail,
       'string_fromcharcodes_test': skip_timeout,
       'string_operations_with_null_test': fail,
       'symbol_reserved_word_test_06_multi': fail,
       'symbol_reserved_word_test_09_multi': fail,
       'symbol_reserved_word_test_12_multi': fail,
       'throw_half_surrogate_pair_test_01_multi': fail,
       'unicode_test': firefox_fail,
-      'uri_parameters_all_test': firefox_fail,
+      'uri_parameters_all_test': is.firefox('<=50') ? fail : pass,
       // TODO(rnystrom): Times out because it tests a huge number of
       // combinations of URLs (4 * 5 * 5 * 8 * 6 * 6 * 4 = 115200).
       'uri_parse_test': skip_timeout,
-      'uri_test': firefox_fail,
+      'uri_test': is.firefox('<=50') ? fail : pass,
 
       'list_insert_test': fail,
       'list_removeat_test': fail,
       'set_test': fail, // runtime strong mode reject
     },
 
     'corelib/regexp': {
       'default_arguments_test': fail,
       'UC16_test': firefox_fail,
     },
@@ skipping 530 matching lines @@
 
     for (let action of unittest_tests) {
       try {
         action();
       } catch (e) {
         console.error("Caught error tying to setup test:", e);
       }
     }
   });
 });