Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: chrome/browser/task_manager/providers/arc/arc_process_task_provider.cc

Issue 2655633002: [task_manager] Add ARC process whitelist. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/providers/arc/arc_process_task_provider.cc
diff --git a/chrome/browser/task_manager/providers/arc/arc_process_task_provider.cc b/chrome/browser/task_manager/providers/arc/arc_process_task_provider.cc
index e843756d4671f0e54f6f8146e6282c04d17fe193..56483a63001879a8c92f14a06de7eff875211577 100644
--- a/chrome/browser/task_manager/providers/arc/arc_process_task_provider.cc
+++ b/chrome/browser/task_manager/providers/arc/arc_process_task_provider.cc
@@ -60,6 +60,10 @@ void ArcProcessTaskProvider::UpdateProcessList(
nspid_to_remove.insert(entry.first);
for (const auto& entry : processes) {
+ // Skip adding or updating processes we will not display.
+ if (!whitelist_.ShouldDisplayProcess(entry))
Luis Héctor Chávez 2017/01/24 17:09:41 this does not look very whitelist-y to me :P (othe
Eliot Courtney 2017/01/25 02:08:12 Yeah, good point. Done.
+ continue;
+
if (nspid_to_remove.erase(entry.nspid()) == 0) {
// New arc process.
std::unique_ptr<ArcProcessTask>& task = (*pid_to_task)[entry.nspid()];

Powered by Google App Engine
This is Rietveld 408576698