Chromium Code Reviews| Index: chrome/browser/resources/extensions/extension_list.js |
| diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js |
| index a3b02a57f5bf4ad81cfcf91829e408b627cc1ac4..afb4a464027de8fdffb5d19b0525ed0717b56a84 100644 |
| --- a/chrome/browser/resources/extensions/extension_list.js |
| +++ b/chrome/browser/resources/extensions/extension_list.js |
| @@ -88,7 +88,7 @@ cr.define('options', function() { |
| if (extension.managedInstall) { |
| node.classList.add('may-not-modify'); |
| node.classList.add('may-not-remove'); |
| - } else if (extension.suspiciousInstall) { |
| + } else if (extension.suspiciousInstall || extension.corruptInstall) { |
| node.classList.add('may-not-modify'); |
| } |
| @@ -223,10 +223,12 @@ cr.define('options', function() { |
| // The 'Enabled' checkbox. |
| var enable = node.querySelector('.enable-checkbox'); |
| enable.hidden = false; |
| - enable.querySelector('input').disabled = extension.managedInstall || |
| - extension.suspiciousInstall; |
| + var hosedExtension = |
|
asargent_no_longer_on_chrome
2014/05/02 16:53:40
nice variable name!
|
| + extension.suspiciousInstall || extension.corruptInstall; |
| + enable.querySelector('input').disabled = |
| + extension.managedInstall || hosedExtension; |
|
Bernhard Bauer
2014/05/05 11:27:18
You could probably extract this into a variable th
Finnur
2014/05/05 13:02:02
Done. Antony won't be happy I ruined his favorite
|
| - if (!extension.managedInstall && !extension.suspiciousInstall) { |
| + if (!extension.managedInstall && !hosedExtension) { |
| enable.addEventListener('click', function(e) { |
| // When e.target is the label instead of the checkbox, it doesn't |
| // have the checked property and the state of the checkbox is |
| @@ -282,9 +284,15 @@ cr.define('options', function() { |
| // Then the 'managed, cannot uninstall/disable' message. |
| if (extension.managedInstall) { |
| node.querySelector('.managed-message').hidden = false; |
| - } else if (extension.suspiciousInstall) { |
| - // Then the 'This isn't from the webstore, looks suspicious' message. |
| - node.querySelector('.suspicious-install-message').hidden = false; |
| + } else { |
| + if (extension.suspiciousInstall) { |
| + // Then the 'This isn't from the webstore, looks suspicious' message. |
| + node.querySelector('.suspicious-install-message').hidden = false; |
| + } |
| + if (extension.corruptInstall) { |
| + // Then the 'This is a corrupt extension' message. |
| + node.querySelector('.corrupt-install-message').hidden = false; |
| + } |
| } |
| // Then active views. |