Add a note to chrome://extensions to explain when an extension has been...

chrome/browser/resources/extensions/extension_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="extension_error.js"></include>
 
 cr.define('options', function() {
   'use strict';
 
   /**
@@ skipping 70 matching lines @@
           '.extension-list-item-wrapper');
       var node = template.cloneNode(true);
       node.id = extension.id;
 
       if (!extension.enabled || extension.terminated)
         node.classList.add('inactive-extension');
 
       if (extension.managedInstall) {
         node.classList.add('may-not-modify');
         node.classList.add('may-not-remove');
-      } else if (extension.suspiciousInstall) {
+      } else if (extension.suspiciousInstall || extension.corruptInstall) {
         node.classList.add('may-not-modify');
       }
 
       var idToHighlight = this.getIdQueryParam_();
       if (node.id == idToHighlight)
         node.classList.add('extension-highlight');
 
       var item = node.querySelector('.extension-list-item');
       // Prevent the image cache of extension icon by using the reloaded
       // timestamp as a query string. The timestamp is recorded when the user
@@ skipping 114 matching lines @@
             chrome.send('extensionSettingsLaunch', [extension.id]);
           });
           launch.hidden = false;
         }
       }
 
       if (!extension.terminated) {
         // The 'Enabled' checkbox.
         var enable = node.querySelector('.enable-checkbox');
         enable.hidden = false;
-        enable.querySelector('input').disabled = extension.managedInstall ||
-                                                 extension.suspiciousInstall;
+        var hosedExtension =

[asargent_no_longer_on_chrome, 2014/05/02 16:53:40]

nice variable name!

+            extension.suspiciousInstall || extension.corruptInstall;
+        enable.querySelector('input').disabled =
+            extension.managedInstall || hosedExtension;

[Bernhard Bauer, 2014/05/05 11:27:18]

You could probably extract this into a variable that you could also use below?

[Finnur, 2014/05/05 13:02:02]

Done. Antony won't be happy I ruined his favorite variable name... ;)

 
-        if (!extension.managedInstall && !extension.suspiciousInstall) {
+        if (!extension.managedInstall && !hosedExtension) {
           enable.addEventListener('click', function(e) {
             // When e.target is the label instead of the checkbox, it doesn't
             // have the checked property and the state of the checkbox is
             // left unchanged.
             var checked = e.target.checked;
             if (checked == undefined)
               checked = !e.currentTarget.querySelector('input').checked;
             chrome.send('extensionSettingsEnable',
                         [extension.id, checked ? 'true' : 'false']);
 
@@ skipping 35 matching lines @@
       if (extension.isUnpacked) {
         var loadPath = node.querySelector('.load-path');
         loadPath.hidden = false;
         loadPath.querySelector('span:nth-of-type(2)').textContent =
             ' ' + extension.path;
       }
 
       // Then the 'managed, cannot uninstall/disable' message.
       if (extension.managedInstall) {
         node.querySelector('.managed-message').hidden = false;
-      } else if (extension.suspiciousInstall) {
-        // Then the 'This isn't from the webstore, looks suspicious' message.
-        node.querySelector('.suspicious-install-message').hidden = false;
+      } else {
+        if (extension.suspiciousInstall) {
+          // Then the 'This isn't from the webstore, looks suspicious' message.
+          node.querySelector('.suspicious-install-message').hidden = false;
+        }
+        if (extension.corruptInstall) {
+          // Then the 'This is a corrupt extension' message.
+          node.querySelector('.corrupt-install-message').hidden = false;
+        }
       }
 
       // Then active views.
       if (extension.views.length > 0) {
         var activeViews = node.querySelector('.active-views');
         activeViews.hidden = false;
         var link = activeViews.querySelector('a');
 
         extension.views.forEach(function(view, i) {
           var displayName = view.generatedBackgroundPage ?
@@ skipping 67 matching lines @@
           topScroll -= pad / 2;
         setScrollTopForDocument(document, topScroll);
       }
     },
   };
 
   return {
     ExtensionsList: ExtensionsList
   };
 });