Issue 265563004: Add a note to chrome://extensions to explain when an extension has been...

Issue 265563004: Add a note to chrome://extensions to explain when an extension has been... (Closed)

Created:
6 years, 7 months ago by Finnur

Modified:
6 years, 7 months ago

Reviewers:
Bernhard Bauer, asargent_no_longer_on_chrome

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add a note to chrome://extensions to explain when an extension has been disabled due to corruption. BUG=369466 R=asargent@chromium.org, bauerb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268158

Patch Set 5 : Addressing review comments #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -11 lines)			Patch
M	chrome/browser/resources/extensions/extension_list.js	View	1 2 3 4	3 chunks	+15 lines, -7 lines	0 comments	Download
M	chrome/browser/resources/extensions/extensions.html	View	1 2 3	1 chunk	+9 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/extensions/extension_settings_handler.cc	View	1 2 3 4	2 chunks	+12 lines, -2 lines	0 comments	Download
M	chrome/common/url_constants.h	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/url_constants.cc	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	extensions/common/extension.h	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Finnur

jhawkins: OWNERS for chrome/browser/resources ? Antony, mind being the main reviewer? I followed a similar ...

6 years, 7 months ago (2014-05-02 11:48:09 UTC) #1

asargent_no_longer_on_chrome

lgtm https://codereview.chromium.org/265563004/diff/40001/chrome/browser/resources/extensions/extension_list.js File chrome/browser/resources/extensions/extension_list.js (right): https://codereview.chromium.org/265563004/diff/40001/chrome/browser/resources/extensions/extension_list.js#newcode226 chrome/browser/resources/extensions/extension_list.js:226: var hosedExtension = nice variable name!

6 years, 7 months ago (2014-05-02 16:53:40 UTC) #2

Bernhard Bauer

LGTM https://codereview.chromium.org/265563004/diff/40001/chrome/browser/resources/extensions/extension_list.js File chrome/browser/resources/extensions/extension_list.js (right): https://codereview.chromium.org/265563004/diff/40001/chrome/browser/resources/extensions/extension_list.js#newcode229 chrome/browser/resources/extensions/extension_list.js:229: extension.managedInstall || hosedExtension; You could probably extract this ...

6 years, 7 months ago (2014-05-05 11:27:18 UTC) #3

Finnur

Thanks Bernhard! https://codereview.chromium.org/265563004/diff/40001/chrome/browser/resources/extensions/extension_list.js File chrome/browser/resources/extensions/extension_list.js (right): https://codereview.chromium.org/265563004/diff/40001/chrome/browser/resources/extensions/extension_list.js#newcode229 chrome/browser/resources/extensions/extension_list.js:229: extension.managedInstall || hosedExtension; On 2014/05/05 11:27:18, Bernhard ...

6 years, 7 months ago (2014-05-05 13:02:02 UTC) #4

Finnur

6 years, 7 months ago (2014-05-05 13:11:45 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 manually as r268158 (presubmit successful).

Expand Messages | Collapse Messages