Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 265563002: Revert of Use new people.get api instead of oauth2/v1/userinfo. (Closed)

Created:
6 years, 7 months ago by Michael Achenbach
Modified:
6 years, 7 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Revert of Use new people.get api instead of oauth2/v1/userinfo. (https://codereview.chromium.org/257773002/) Reason for revert: [Sheriff]Speculative revert for breaking CrOS: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/23489 Will reland if it doesn't help. Original issue's description: > Use new people.get api instead of oauth2/v1/userinfo. > Consolidate all uses into main helper class. > > Details about new api: https://developers.google.com/+/api/latest/people/get > > Format of returned response: https://developers.google.com/+/api/latest/people#resource > > BUG=320354 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267068 TBR=atwilson@chromium.org,noms@chromium.org,guohui@chromium.org,gene@chromium.org,rogerta@chromium.org NOTREECHECKS=true NOTRY=true BUG=320354 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267114

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -307 lines) Patch
M chrome/browser/chromeos/policy/policy_oauth2_token_fetcher.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/wildcard_login_checker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc View 4 chunks +3 lines, -10 lines 0 comments Download
M chrome/browser/profiles/profile_downloader.h View 5 chunks +3 lines, -11 lines 0 comments Download
M chrome/browser/profiles/profile_downloader.cc View 6 chunks +93 lines, -75 lines 0 comments Download
M chrome/browser/profiles/profile_downloader_unittest.cc View 2 chunks +25 lines, -20 lines 0 comments Download
M chrome/browser/signin/account_reconcilor_unittest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_client_registration_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/user_info_fetcher.h View 3 chunks +7 lines, -20 lines 0 comments Download
M components/policy/core/common/cloud/user_info_fetcher.cc View 2 chunks +53 lines, -20 lines 0 comments Download
M components/policy/core/common/cloud/user_info_fetcher_unittest.cc View 4 chunks +4 lines, -7 lines 0 comments Download
M google_apis/gaia/gaia_constants.h View 2 chunks +0 lines, -4 lines 0 comments Download
M google_apis/gaia/gaia_constants.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M google_apis/gaia/gaia_oauth_client.h View 3 chunks +3 lines, -15 lines 0 comments Download
M google_apis/gaia/gaia_oauth_client.cc View 7 chunks +9 lines, -51 lines 0 comments Download
M google_apis/gaia/gaia_oauth_client_unittest.cc View 2 chunks +14 lines, -45 lines 0 comments Download
M google_apis/gaia/gaia_urls.h View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/gaia/gaia_urls.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
Created Revert of Use new people.get api instead of oauth2/v1/userinfo.
6 years, 7 months ago (2014-04-30 07:16:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/265563002/1
6 years, 7 months ago (2014-04-30 07:17:07 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 07:18:23 UTC) #3
Message was sent while issue was closed.
Change committed as 267114

Powered by Google App Engine
This is Rietveld 408576698