mash: Relay some Chrome aura window properties to Ash.

ui/views/mus/desktop_window_tree_host_mus.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/mus/desktop_window_tree_host_mus.h"
 
 #include "base/memory/ptr_util.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/client/cursor_client.h"
@@ skipping 164 matching lines @@
     const std::map<std::string, std::vector<uint8_t>>* mus_properties)
     : aura::WindowTreeHostMus(MusClient::Get()->window_tree_client(),
                               mus_properties),
       native_widget_delegate_(native_widget_delegate),
       desktop_native_widget_aura_(desktop_native_widget_aura),
       fullscreen_restore_state_(ui::SHOW_STATE_DEFAULT),
       close_widget_factory_(this) {
   aura::Env::GetInstance()->AddObserver(this);
   MusClient::Get()->AddObserver(this);
   native_widget_delegate_->AsWidget()->AddObserver(this);
+  desktop_native_widget_aura->content_window()->AddObserver(this);

[sky, 2017/01/27 16:20:20]

You never remove this observer.

[msw, 2017/01/27 19:11:34]

Now done in the destructor.

   // DesktopNativeWidgetAura registers the association between |content_window_|
   // and Widget, but code may also want to go from the root (window()) to the
   // Widget. This call enables that.
   NativeWidgetAura::RegisterNativeWidgetForWindow(desktop_native_widget_aura,
                                                   window());
   // TODO: use display id and bounds if available, likely need to pass in
   // InitParams for that.
 }
 
 DesktopWindowTreeHostMus::~DesktopWindowTreeHostMus() {
@@ skipping 477 matching lines @@
       native_widget_delegate_->AsWidget()->non_client_view();
   if (non_client_view) {
     non_client_view->Layout();
     non_client_view->SchedulePaint();
   }
 
   SendClientAreaToServer();
   SendHitTestMaskToServer();
 }
 
+void DesktopWindowTreeHostMus::OnWindowPropertyChanged(aura::Window* window,
+                                                       const void* key) {
+  // Ignore this; window property changes are handled elsewhere.
+}
+
 void DesktopWindowTreeHostMus::OnWidgetActivationChanged(Widget* widget,
                                                          bool active) {
   // TODO(erg): Theoretically, this shouldn't be necessary. We should be able
   // to just set |is_active_| in OnNativeWidgetActivationChanged() above,
   // instead of asking the Widget to change the activation and have the widget
   // then tell us the activation has changed. But if we do that, focus breaks.
   is_active_ = active;
 }
 
+void DesktopWindowTreeHostMus::OnWindowPropertyChanged(aura::Window* window,
+                                                       const void* key,
+                                                       intptr_t old) {
+  MusClient::Get()->OnWindowPropertyChanged(window, key);

[sky, 2017/01/27 16:20:20]

I recommend something like this:

MusClient::Get()->MirrorPropertyFromWidgetWindowToRootWindow(window, key,
window());

Hopefully that better conveys what is expected to happen when this occurs. Does
it make it any clearer to you?

I suggested lumping this on MusClientObserver, but I think it would be clearer
to have an explicit interface for this function, perhaps MusPropertyMirror.
WDYT?

[msw, 2017/01/27 19:11:34]

I tried to adopt your suggestions, let me know what you think.

+}
+
 void DesktopWindowTreeHostMus::ShowImpl() {
   native_widget_delegate_->OnNativeWidgetVisibilityChanging(true);
   // Using ui::SHOW_STATE_NORMAL matches that of DesktopWindowTreeHostX11.
   ShowWindowWithState(ui::SHOW_STATE_NORMAL);
   WindowTreeHostMus::ShowImpl();
   native_widget_delegate_->OnNativeWidgetVisibilityChanged(true);
 }
 
 void DesktopWindowTreeHostMus::HideImpl() {
   native_widget_delegate_->OnNativeWidgetVisibilityChanging(false);
@@ skipping 29 matching lines @@
     aura::client::FocusClient* focus_client,
     aura::Window* window) {
   if (window == this->window()) {
     desktop_native_widget_aura_->HandleActivationChanged(true);
   } else if (is_active_) {
     desktop_native_widget_aura_->HandleActivationChanged(false);
   }
 }
 
 }  // namespace views