Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: content/browser/web_contents/web_drag_dest_mac.mm

Issue 2655463015: Correctly set dragLeave and dragEnd coords for OOPIF drag and drop (Closed)
Patch Set: Added checks for null RWH on drag end Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_drag_dest_mac.mm
diff --git a/content/browser/web_contents/web_drag_dest_mac.mm b/content/browser/web_contents/web_drag_dest_mac.mm
index 458b01aaeedaa1d829cdc852a0a93d553d3c3523..37ed2657ac19f8a1dbbdc54b9cff3dae5a578e6a 100644
--- a/content/browser/web_contents/web_drag_dest_mac.mm
+++ b/content/browser/web_contents/web_drag_dest_mac.mm
@@ -10,6 +10,7 @@
#include "content/browser/renderer_host/render_view_host_impl.h"
#include "content/browser/renderer_host/render_widget_host_impl.h"
#include "content/browser/renderer_host/render_widget_host_input_event_router.h"
+#include "content/browser/renderer_host/render_widget_host_view_base.h"
#include "content/browser/web_contents/web_contents_impl.h"
#include "content/public/browser/web_contents_delegate.h"
#include "content/public/browser/web_drag_dest_delegate.h"
@@ -215,7 +216,7 @@ content::GlobalRoutingID GetRenderViewHostID(content::RenderViewHost* rvh) {
delegate_->OnDragLeave();
if (currentRWHForDrag_) {
- currentRWHForDrag_->DragTargetDragLeave();
+ currentRWHForDrag_->DragTargetDragLeave(gfx::Point(), gfx::Point());
currentRWHForDrag_.reset();
}
dropData_.reset();
@@ -243,8 +244,23 @@ content::GlobalRoutingID GetRenderViewHostID(content::RenderViewHost* rvh) {
// TODO(paulmeyer): The dragging delegates may now by invoked multiple times
// per drag, even without the drag ever leaving the window.
if (targetRWH != currentRWHForDrag_.get()) {
- if (currentRWHForDrag_)
- currentRWHForDrag_->DragTargetDragLeave();
+ if (currentRWHForDrag_) {
+ gfx::Point transformedLeavePoint = gfx::Point(viewPoint.x, viewPoint.y);
+ gfx::Point transformedScreenPoint =
+ gfx::Point(screenPoint.x, screenPoint.y);
+ content::RenderWidgetHostViewBase* rootView =
+ static_cast<content::RenderWidgetHostViewBase*>(
+ webContents_->GetRenderWidgetHostView());
+ content::RenderWidgetHostViewBase* currentDragView =
+ static_cast<content::RenderWidgetHostViewBase*>(
+ currentRWHForDrag_->GetView());
+ rootView->TransformPointToCoordSpaceForView(
+ transformedLeavePoint, currentDragView, &transformedLeavePoint);
+ rootView->TransformPointToCoordSpaceForView(
+ transformedScreenPoint, currentDragView, &transformedScreenPoint);
+ currentRWHForDrag_->DragTargetDragLeave(transformedLeavePoint,
+ transformedScreenPoint);
+ }
[self draggingEntered:info view:view];
}
@@ -284,7 +300,8 @@ content::GlobalRoutingID GetRenderViewHostID(content::RenderViewHost* rvh) {
if (targetRWH != currentRWHForDrag_.get()) {
if (currentRWHForDrag_)
- currentRWHForDrag_->DragTargetDragLeave();
+ currentRWHForDrag_->DragTargetDragLeave(
+ transformedPt, gfx::Point(screenPoint.x, screenPoint.y));
[self draggingEntered:info view:view];
}
« no previous file with comments | « content/browser/web_contents/web_contents_view_aura.cc ('k') | content/browser/web_contents/web_drag_source_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698