Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Unified Diff: chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc

Issue 2655463015: Correctly set dragLeave and dragEnd coords for OOPIF drag and drop (Closed)
Patch Set: Cleanup Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc
diff --git a/chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc b/chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc
index f102bd096fcb56faf03fc284bc68ef897721f221..0e5b35c3cd2d855eeadfdd3cc0a997502de2ceeb 100644
--- a/chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc
+++ b/chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc
@@ -928,12 +928,8 @@ void DragAndDropBrowserTest::DragImageBetweenFrames_Step2(
{ // Verify dragleave DOM event.
std::string dragleave_event;
- // TODO(paulmeyer): https://crbug.com/669695: Need to unify coordinates
- // passed to dragend when OOPIFs are present or not.
- state->expected_dom_event_data.set_expected_client_position(
- "<no expectation>");
- state->expected_dom_event_data.set_expected_page_position(
- "<no expectation>");
+ state->expected_dom_event_data.set_expected_client_position("(355, 150)");
+ state->expected_dom_event_data.set_expected_page_position("(355, 150)");
EXPECT_TRUE(
dragleave_event_waiter.WaitForNextMatchingEvent(&dragleave_event));
@@ -1019,8 +1015,8 @@ void DragAndDropBrowserTest::DragImageBetweenFrames_Step3(
state->expected_dom_event_data.set_expected_drop_effect("copy");
state->expected_dom_event_data.set_expected_mime_types("");
- // TODO(paulmeyer): https://crbug.com/669695: Need to unify coordinates
- // passed to dragend when OOPIFs are present or not.
+ // TODO: https://crbug.com/686136: dragEnd coordinates for non-OOPIF
+ // scenarios are currently broken.
state->expected_dom_event_data.set_expected_client_position(
"<no expectation>");
state->expected_dom_event_data.set_expected_page_position(
« no previous file with comments | « no previous file | components/test_runner/event_sender.cc » ('j') | content/browser/web_contents/web_contents_view_aura.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698